From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-input <linux-input@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 0/1] Input: soc_button_array - Work around DSDTs which modify the irqflags
Date: Mon, 14 Sep 2020 15:52:05 +0200 [thread overview]
Message-ID: <897df830-4806-0118-6a27-0025268da1f5@redhat.com> (raw)
In-Reply-To: <CAHp75VemDbswE9+yXMut1vbYvWwcTAd+b_Ry05_0QWbfnCSv9g@mail.gmail.com>
Hi,
On 9/14/20 10:00 AM, Andy Shevchenko wrote:
> On Mon, Sep 14, 2020 at 10:45 AM Hans de Goede <hdegoede@redhat.com> wrote:
>> On 9/14/20 8:12 AM, Dmitry Torokhov wrote:
>>> On Sun, Sep 06, 2020 at 02:20:15PM +0200, Hans de Goede wrote:
>
> ...
>
>>>> The soc_button_array code really is x86 specific glue code to translate
>>>> various incarnations of gpio-keys in ACPI tables to gpio_keys_platform_data.
>>>> As such I wonder if it would not be better to move this driver to
>>>> drivers/platform/x86?
>
> AFAIU the above is a justification why PDx86 suits better to host it.
Correct.
>>>> I seem to be doing most if not all of the recent work on soc_button_array,
>>>> and soon I will be a co-maintainer of drivers/platform/x86. So having it
>>>> there and adding me in MAINTAINERS as maintaining it seems to be best?
>>>>
>>>> If you want I can do a patch moving soc_button_array to drivers/platform/x86
>>>> and then add the other 3 patches on top and then we can merge all of this
>>>> through drivers/platform/x86?
>>>
>>> Sorry, misread this first time through, so already merged the 3 patches,
>>> but I to not mind at all moving the driver to platform tree. If you send
>>> me such a patch I will apply it.
>>
>> Ok.
>>
>> Andy are you ok with moving the driver to the pdx86 tree too?
>
> Taking into consideration the above, if I read it correctly, I agree.
> Feel free to add my Ack.
Ok, since Dmitry's tree currently has some changes to soc_button_array.c,
the plan is to merge the patch through Dmitry's tree.
I will prepare a patch with your Acked-by and submit it.
Regards,
Hans
next prev parent reply other threads:[~2020-09-14 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 12:20 [PATCH 0/1] Input: soc_button_array - Work around DSDTs which modify the irqflags Hans de Goede
2020-09-06 12:20 ` [PATCH] " Hans de Goede
2020-09-14 6:09 ` Dmitry Torokhov
2020-09-14 6:12 ` [PATCH 0/1] " Dmitry Torokhov
2020-09-14 7:45 ` Hans de Goede
2020-09-14 8:00 ` Andy Shevchenko
2020-09-14 13:52 ` Hans de Goede [this message]
2020-09-14 14:08 ` Hans de Goede
2020-09-14 18:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897df830-4806-0118-6a27-0025268da1f5@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).