From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE8EC4332B for ; Fri, 20 Mar 2020 03:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 610FC20724 for ; Fri, 20 Mar 2020 03:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbgCTDhl (ORCPT ); Thu, 19 Mar 2020 23:37:41 -0400 Received: from esa3.mentor.iphmx.com ([68.232.137.180]:63475 "EHLO esa3.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726614AbgCTDhl (ORCPT ); Thu, 19 Mar 2020 23:37:41 -0400 IronPort-SDR: qaV3T4b5SCul8BtOM2bZ2KM0Gqixsh1HcMKDLSGfafdKq/1Ip8kjlxHSP/4leC1xI0y6mpZl+V 06w2IkpOek0+N7cOp1t9RwHQIw1ZRAbIBMpkZv4UIWOYjvfVqZxiJNnORclBiTt8FbHZgzzmCF XrmDmDUpUAMra0bYcGieaYvtgQG1AWUrqT5jcbjeYHUiDJH9bEB/enz517W1ZUpPVZW2pwDLDQ zz0TsDbTweA1z1y7oJ4Xm7y/wYHE9bQCVH/FnhUJLstFEXpdKTmzzqbD4C4CRutRG5QhVR68A5 ric= X-IronPort-AV: E=Sophos;i="5.72,283,1580803200"; d="scan'208";a="46924902" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 19 Mar 2020 19:37:40 -0800 IronPort-SDR: ULM96d0CGVZ3Rv6KxkX4zi4MX9lUX6iuCYseznlFFAWG3nRK0ylXEwlrBGHxpdzoNmKxB7cLyQ HVOFcNX5OvzdWMMxtJpJLPNwIZjCmY40f9R/oy7+M74J1JH/XDoDRty/RtTRXJKech0pPNJxEH Ytt0ffAu1v8sv9Uvdnd8nUILMoBLiRF811+7oXfj+q32I9g3I8A3F6hPp/Y34rTrbWoCaFn4hh cBnXgI6kU7UsYKcvUS+L+WvuvgIGQkRE3g+ndQ+45DD+ofFNeTDXb6lr+h8H+TS4Nho9WYury+ IWc= Subject: Re: [PATCH v7 00/48] atmel_mxt_ts misc To: Dmitry Osipenko , , , , , , CC: , , , References: <20200212084218.32344-1-jiada_wang@mentor.com> From: "Wang, Jiada" Message-ID: <89e4bb0b-b2eb-0b67-4307-fb2af914b1c0@mentor.com> Date: Fri, 20 Mar 2020 12:37:25 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SVR-ORW-MBX-05.mgc.mentorg.com (147.34.90.205) To svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hello Dmitry I have submitted v8 patch-set to address your comments towards v7 patch-set, most of checkpatch warnings and errors have been addressed, But I didn't update for following two types of warnings since I want to keep consistency with legacy code WARNING: DEVICE_ATTR unusual permissions '0600' used #290: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3761: +static DEVICE_ATTR(debug_v2_enable, 0600, NULL, WARNING: Consider renaming function(s) 'mxt_debug_notify_show' to 'debug_notify_show' #292: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3763: +static DEVICE_ATTR(debug_notify, 0444, mxt_debug_notify_show, NULL); please let me know if you have different view on this Thanks, Jiada On 2020/03/13 0:21, Dmitry Osipenko wrote: > 12.02.2020 11:41, Jiada Wang пишет: >> This patch-set forward ports Nick Dyer's work in ndyer/linux github repository >> as long as some other features and fixes >> >> Balasubramani Vivekanandan (2): >> Input: atmel_mxt_ts: Limit the max bytes transferred in an i2c >> transaction >> Input: atmel_mxt_ts: use gpiod_set_value_cansleep for reset pin >> >> Dean Jenkins (1): >> Input: atmel_mxt_ts: return error from >> mxt_process_messages_until_invalid() >> >> Deepak Das (6): >> Input: Atmel: improve error handling in mxt_start() >> Input: Atmel: improve error handling in mxt_initialize() >> Input: Atmel: improve error handling in mxt_update_cfg() >> Input: Atmel: Improve error handling in mxt_initialize_input_device() >> Input: Atmel: handle ReportID "0x00" while processing T5 messages >> Input: Atmel: use T44 object to process T5 messages >> >> George G. Davis (1): >> input: atmel_mxt_ts: export GPIO reset line via sysfs >> >> Jiada Wang (3): >> Input: introduce input_mt_report_slot_inactive >> Input: atmel_mxt_ts - eliminate data->raw_info_block >> Input: atmel_mxt_ts - Fix compilation warning >> >> Karl Tsou (1): >> Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msgs >> >> Kautuk Consul (2): >> Input: atmel_mxt_ts - Change call-points of mxt_free_* functions >> Input: atmel_mxt_ts - rely on calculated_crc rather than file >> config_crc >> >> Naveen Chakka (2): >> input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen >> status >> input: atmel_mxt_ts: added sysfs interface to update atmel T38 data >> >> Nick Dyer (26): >> Input: atmel_mxt_ts - rework sysfs init/remove >> Input: atmel_mxt_ts - only read messages in mxt_acquire_irq() when >> necessary >> Input: atmel_mxt_ts - split large i2c transfers into blocks >> Input: atmel_mxt_ts - output status from T48 Noise Supression >> Input: atmel_mxt_ts - output status from T42 Touch Suppression >> Input: atmel_mxt_ts - implement T9 vector/orientation support >> Input: atmel_mxt_ts - implement T15 Key Array support >> Input: atmel_mxt_ts - handle reports from T47 Stylus object >> Input: atmel_mxt_ts - implement support for T107 active stylus >> Input: atmel_mxt_ts - release touch state during suspend >> Input: atmel_mxt_ts - add regulator control support >> Input: atmel_mxt_ts - report failures in suspend/resume >> Input: atmel_mxt_ts - allow specification of firmware file name >> Input: atmel_mxt_ts - handle cfg filename via pdata/sysfs >> Input: atmel_mxt_ts - allow input name to be specified in platform >> data >> Input: atmel_mxt_ts - refactor firmware flash to extract context into >> struct >> Input: atmel_mxt_ts - refactor code to enter bootloader into separate >> func >> Input: atmel_mxt_ts - combine bootloader version query with probe >> Input: atmel_mxt_ts - improve bootloader state machine handling >> Input: atmel_mxt_ts - rename bl_completion to chg_completion >> Input: atmel_mxt_ts - make bootloader interrupt driven >> Input: atmel_mxt_ts - delay enabling IRQ when not using regulators >> Input: atmel_mxt_ts - implement I2C retries >> Input: atmel_mxt_ts - orientation is not present in hover >> Input: atmel_mxt_ts - implement debug output for messages >> Input: atmel_mxt_ts - implement improved debug message interface >> >> Nikhil Ravindran (1): >> Input: atmel_mxt_ts: Add support for run self-test routine. >> >> Sanjeev Chugh (1): >> Input: atmel_mxt_ts: Implement synchronization during various >> operation >> >> karl tsou (1): >> Input: atmel_mxt_ts - add config checksum attribute to sysfs >> >> keerthikumarp (1): >> input: atmel_mxt_ts: Add Missing Delay for reset handling of Atmel >> touch panel controller in detachable displays. >> >> --- >> v7: >> Fix regression found when updating firmware >> Following commits have been updated to fix regression found when >> updating firmware >> Input: atmel_mxt_ts - improve bootloader state machine handling >> Input: atmel_mxt_ts - make bootloader interrupt driven >> input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen status >> Input: atmel_mxt_ts: Implement synchronization during various operation >> >> v6: >> Fix issue in commit ("Input: introduce input_mt_report_slot_inactive") >> reported by kernel test robot >> >> v5: >> Following commits have been updated to address warnings & errors >> reported by kbuild test robot >> Input: atmel_mxt_ts - make bootloader interrupt driven >> Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msgs >> >> Following commit has been updated >> Input: introduce input_mt_report_slot_inactive >> >> v4: >> Following commit in v3 patch-set has been removed >> Input: switch to use return value of input_mt_report_slot_state >> >> Following commit has been updated to address checkpatch warning >> Input: atmel_mxt_ts: Implement synchronization during various operation >> >> v3: >> Following commits have been updated compared to v2 patchset >> Input: atmel_mxt_ts - implement debug output for messages >> - added inline comment >> Input: atmel_mxt_ts - add debug for T92 gesture and T93 touch seq msg >> - changed dev_info() to dev_dbg() >> >> v2: >> Following commit in v1 patchset has been split into two commits >> Input: introduce input_mt_report_slot_inactive >> >> Following commits have been updated compared to v1 patchset >> Input: atmel_mxt_ts - split large i2c transfers into blocks >> Input: atmel_mxt_ts - output status from T42 Touch Suppression >> >> Following commits in v1 patchset have been squashed >> Input: touchscreen: Atmel: Add device tree support for T15 key array >> objects >> Input: atmel_mxt_ts - check data->input_dev is not null in >> mxt_input_sync() >> Input: atmel_mxt_ts - check firmware format before entering bootloader >> Input: atmel_mxt_ts: update stale use_retrigen_workaround flag >> input: atmel_mxt_ts: move bootloader probe from mxt_initialize() >> input: Atmel: limit the max bytes transferred while reading T5 messages >> Input: atmel_mxt_ts: Use msecs_to_jiffies() instead of HZ >> Input: atmel_mxt_ts: Use complete when in_bootloader true >> Input: atmel_mxt_ts: Prevent crash due to freeing of input device >> input: atmel_mxt_ts: Add NULL check for sysfs attribute debug_msg_attr >> >> Following commits in v1 patchset have been dropped: >> Input: atmel_mxt_ts - configure and use gpios as real gpios >> Input: touchscreen: Atmel: Enable IRQ_DISABLE_UNLAZY flag for interrupt >> Input: atmel_mxt_ts - add memory access interface via sysfs >> Input: atmel_mxt_ts: Remove sysfs attributes during driver detach >> Input: atmel_mxt_ts: Avoid race condition in freeing of input device >> >> >> v1: initial version >> --- >> .../bindings/input/atmel,maxtouch.txt | 14 + >> MAINTAINERS | 1 + >> drivers/hid/hid-alps.c | 3 +- >> drivers/hid/hid-multitouch.c | 6 +- >> drivers/input/misc/xen-kbdfront.c | 2 +- >> drivers/input/mouse/elan_i2c_core.c | 2 +- >> drivers/input/touchscreen/atmel_mxt_ts.c | 2270 ++++++++++++++--- >> drivers/input/touchscreen/cyttsp4_core.c | 5 +- >> drivers/input/touchscreen/cyttsp_core.c | 2 +- >> drivers/input/touchscreen/melfas_mip4.c | 4 +- >> drivers/input/touchscreen/mms114.c | 2 +- >> drivers/input/touchscreen/raspberrypi-ts.c | 2 +- >> drivers/input/touchscreen/stmfts.c | 2 +- >> include/dt-bindings/input/atmel_mxt_ts.h | 22 + >> include/linux/input/mt.h | 5 + >> 15 files changed, 1985 insertions(+), 357 deletions(-) >> create mode 100644 include/dt-bindings/input/atmel_mxt_ts.h >> > > Hello Jiada, > > Please run all the patches through `scripts/checkpatch.pl --strict` and > fix all the reported problems. > > Otherwise this is a very good series, it makes MXT1386 to work because > I2C retying is indeed required for that controller. >