linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: da7280 - fix missing error test
@ 2020-12-15 18:12 Dmitry Torokhov
  2020-12-16  1:14 ` Roy Im
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2020-12-15 18:12 UTC (permalink / raw)
  To: Roy Im; +Cc: linux-input, linux-kernel

An "if" testing for error condition has accidentally been dropped from
the code.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: cd3f609823a5 ("Input: new da7280 haptic driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/misc/da7280.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/misc/da7280.c b/drivers/input/misc/da7280.c
index 37568b00873d..2f698a8c1d65 100644
--- a/drivers/input/misc/da7280.c
+++ b/drivers/input/misc/da7280.c
@@ -863,6 +863,7 @@ static void da7280_parse_properties(struct device *dev,
 		gpi_str3[7] = '0' + i;
 		haptics->gpi_ctl[i].polarity = 0;
 		error = device_property_read_string(dev, gpi_str3, &str);
+		if (!error)
 			haptics->gpi_ctl[i].polarity =
 				da7280_haptic_of_gpi_pol_str(dev, str);
 	}
-- 
2.29.2.684.gfbc64c5ab5-goog


-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] Input: da7280 - fix missing error test
  2020-12-15 18:12 [PATCH] Input: da7280 - fix missing error test Dmitry Torokhov
@ 2020-12-16  1:14 ` Roy Im
  0 siblings, 0 replies; 2+ messages in thread
From: Roy Im @ 2020-12-16  1:14 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Roy Im

On Wednesday, December 16, 2020 3:13 AM, Dmitry Torokhov wrote:

> An "if" testing for error condition has accidentally been dropped from the code.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: cd3f609823a5 ("Input: new da7280 haptic driver")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Many thanks for your help.

Reviewed-by: Roy Im <Roy.Im.Opensource@diasemi.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-16  1:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 18:12 [PATCH] Input: da7280 - fix missing error test Dmitry Torokhov
2020-12-16  1:14 ` Roy Im

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).