Linux Input Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Input: move the new KEY_SELECTIVE_SCREENSHOT keycode
@ 2020-03-26 18:27 Dmitry Torokhov
  2020-03-26 18:30 ` Rajat Jain
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2020-03-26 18:27 UTC (permalink / raw)
  To: linux-input
  Cc: Rajat Jain, Harry Cutts, Mathew King, Hans de Goede, linux-kernel

We should try to keep keycodes sequential unless there is a reason to leave
a gap in numbering, so let's move it from 0x280 to 0x27a while we still
can.

Fixes: 3b059da9835c ("Input: allocate keycode for Selective Screenshot key")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 include/uapi/linux/input-event-codes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 008be2609ce1..6923dc7e0298 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -653,7 +653,7 @@
 #define KEY_PRIVACY_SCREEN_TOGGLE	0x279
 
 /* Select an area of screen to be copied */
-#define KEY_SELECTIVE_SCREENSHOT	0x280
+#define KEY_SELECTIVE_SCREENSHOT	0x27a
 
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
-- 
2.26.0.rc2.310.g2932bb562d-goog


-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: move the new KEY_SELECTIVE_SCREENSHOT keycode
  2020-03-26 18:27 [PATCH] Input: move the new KEY_SELECTIVE_SCREENSHOT keycode Dmitry Torokhov
@ 2020-03-26 18:30 ` Rajat Jain
  0 siblings, 0 replies; 2+ messages in thread
From: Rajat Jain @ 2020-03-26 18:30 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: linux-input, Harry Cutts, Mathew King, Hans de Goede,
	Linux Kernel Mailing List

On Thu, Mar 26, 2020 at 11:27 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> We should try to keep keycodes sequential unless there is a reason to leave
> a gap in numbering, so let's move it from 0x280 to 0x27a while we still
> can.
>
> Fixes: 3b059da9835c ("Input: allocate keycode for Selective Screenshot key")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Rajat Jain <rajatja@google.com>

Thanks! My apologies for overlooking.

> ---
>  include/uapi/linux/input-event-codes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 008be2609ce1..6923dc7e0298 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -653,7 +653,7 @@
>  #define KEY_PRIVACY_SCREEN_TOGGLE      0x279
>
>  /* Select an area of screen to be copied */
> -#define KEY_SELECTIVE_SCREENSHOT       0x280
> +#define KEY_SELECTIVE_SCREENSHOT       0x27a
>
>  /*
>   * Some keyboards have keys which do not have a defined meaning, these keys
> --
> 2.26.0.rc2.310.g2932bb562d-goog
>
>
> --
> Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 18:27 [PATCH] Input: move the new KEY_SELECTIVE_SCREENSHOT keycode Dmitry Torokhov
2020-03-26 18:30 ` Rajat Jain

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git