linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: qi feng <fengqi706@gmail.com>
To: jikos@kernel.org
Cc: rydberg@bitmath.org, benjamin.tissoires@redhat.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	fengqi <fengqi@xiaomi.com>,
	lixiaojie5@xiaomi.com
Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID
Date: Thu, 12 Jan 2023 10:46:20 +0800	[thread overview]
Message-ID: <CACOZ=ZU9mOj5Yr7_MJGjOH4wq2uRfXJt=QLZpD0SUQr9R4Vr=g@mail.gmail.com> (raw)
In-Reply-To: <CACOZ=ZW5vpaPpFsQ64nSE3kinUhGDBeDey7odvnGeZFEKys32g@mail.gmail.com>

please help me review this code

thanks a lot

qi feng <fengqi706@gmail.com> 于2023年1月10日周二 17:53写道：
>
> loop more
>
>
> Qi Feng <fengqi706@gmail.com> 于2023年1月9日周一 20:32写道：
> >
> > From: fengqi <fengqi@xiaomi.com>
> >
> > Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> > event is non-existent in current HID driver.
> > So we add this event in hid-input.c
> >
> > Signed-off-by: fengqi <fengqi@xiaomi.com>
> > ---
> >  drivers/hid/hid-input.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 9b59e436df0a..22cca3406b5c 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> >                 case 0x0e5: map_key_clear(KEY_BASSBOOST);       break;
> >                 case 0x0e9: map_key_clear(KEY_VOLUMEUP);        break;
> >                 case 0x0ea: map_key_clear(KEY_VOLUMEDOWN);      break;
> > +               case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS);    break;
> >                 case 0x0f5: map_key_clear(KEY_SLOW);            break;
> >
> >                 case 0x181: map_key_clear(KEY_BUTTONCONFIG);    break;
> > --
> > 2.39.0
> >

  reply	other threads:[~2023-01-12  2:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 12:32 [PATCH] HID: add KEY_CAMERA_FOCUS event in HID Qi Feng
2023-01-10  9:53 ` qi feng
2023-01-12  2:46   ` qi feng [this message]
2023-01-20 17:51 ` Jiri Kosina
2023-01-29  2:59   ` qi feng
2023-01-30 14:28     ` Jiri Kosina
2023-02-02  9:56       ` qi feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACOZ=ZU9mOj5Yr7_MJGjOH4wq2uRfXJt=QLZpD0SUQr9R4Vr=g@mail.gmail.com' \
    --to=fengqi706@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=fengqi@xiaomi.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixiaojie5@xiaomi.com \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).