From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92362C433FE for ; Sun, 6 Dec 2020 15:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5084D23329 for ; Sun, 6 Dec 2020 15:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726147AbgLFPOx (ORCPT ); Sun, 6 Dec 2020 10:14:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgLFPOx (ORCPT ); Sun, 6 Dec 2020 10:14:53 -0500 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B0DC0613D0 for ; Sun, 6 Dec 2020 07:14:12 -0800 (PST) Received: by mail-lj1-x242.google.com with SMTP id q8so12212587ljc.12 for ; Sun, 06 Dec 2020 07:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ewLQDP/8tzLVIjOAB6Z6yBX/hdvnuw9WqxClNkbxi5c=; b=ebMvmXZOn+SFPjj7tRKJ1Hg0BIRHg5+xookwP/W5cirHmg6iPhktYlp+2gAc/z1Igl MCoTL162aPOs/YSVqaV0dJrwuDgHM5bdjWcAIzUXlE6Pk+3LhVuueQ6wQwomppL7QwjO ROSha5rWv1unSTc2Pc5V1ZB98hP4dbvBbKEnXWxo71XL3t0qAzPPG6KuQuy7DBnql3Tb k7b2HPg1EQ1z5e44YOZl4aHSugKhI8bnOi4ndXsp8b6R3M/IaCS71yF6cRzAzsHm8ief 25QVaE93St2D3e04vPrWiBVZlJskrseHCpXsx1k9oLI3L5QFsHtCKJPy3zrZmtY1ITS0 4cWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ewLQDP/8tzLVIjOAB6Z6yBX/hdvnuw9WqxClNkbxi5c=; b=aBsxZnwXYKomZP6c3m6X3UVo9NnMnBr3pZavntnCEfijSQ3oNItzKNChq+SWS+UP/1 hOpfOGuHYtvlDtGktbFi2JRucpBhjdPNB2KU3whxD5l67HwPvYdqKA+ST6kCpyCVfAya unfHgwPTY+i6rLslWFOSNVDiTQN0LWCGqC4BY3LLp6zpNtn+Q4vIwvzfIUKg0unI8nqX vaEU2s+y7VrpHfl3pXQxaKTR0YkJRFF9ODIRXj7016PB1o3YcVsuXgsJpSCZ61TCe9Uy j1r2EGUVjN0eYVJgj2DQCZTOEgDl8+xWjcK6VjXXqmOqqPpVAm1MCFLAh1pwua9B945B NEaA== X-Gm-Message-State: AOAM5305/iWLDqBWAOHuHJ8I6aTTU/cU8fnYRLSessu/tIbDuMcL77Wo laxhq/QZqd5DOe2pZlIvmWWPdu5u1rreoJeGUFhnQQ== X-Google-Smtp-Source: ABdhPJy7Rh18d+1pv9wJ41IJ+1/SLO4A2I29ybUTEusEbi5vnUDxLdouW9sCljOvQyHl/r6VEcE/XS780edAEcMoGYo= X-Received: by 2002:a05:651c:c2:: with SMTP id 2mr6851536ljr.104.1607267651173; Sun, 06 Dec 2020 07:14:11 -0800 (PST) MIME-Version: 1.0 References: <20201205053328.9535-1-digetx@gmail.com> <20201205053328.9535-2-digetx@gmail.com> In-Reply-To: <20201205053328.9535-2-digetx@gmail.com> From: Linus Walleij Date: Sun, 6 Dec 2020 16:13:59 +0100 Message-ID: Subject: Re: [PATCH v1 1/3] dt-bindings: input: atmel_mxt_ts: Document atmel,wakeup-method and wake-GPIO To: Dmitry Osipenko Cc: Nick Dyer , Dmitry Torokhov , Rob Herring , Thierry Reding , Jonathan Hunter , Jiada Wang , Linux Input , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-tegra , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sat, Dec 5, 2020 at 6:34 AM Dmitry Osipenko wrote: > Some Atmel touchscreen controllers have a WAKE line that needs to be > asserted low in order to wake up controller from a deep sleep. Document > the wakeup methods and the wake-GPIO properties. > > Signed-off-by: Dmitry Osipenko Looks really useful! > + atmel,wakeup-method: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + The WAKE line is an active-low input that is used to wake up the touch > + controller from deep-sleep mode before communication with the controller > + could be started. This feature used to minimize current consumption > + when the controller is in deep sleep mode. > + > + The WAKE pin can be connected in one of the following ways: > + 1) left permanently low > + 2) connected to the I2C-compatible SCL pin > + 3) connected to a GPIO pin on the host > + enum: > + - 0 # ATMEL_MXT_WAKEUP_NONE > + - 1 # ATMEL_MXT_WAKEUP_I2C_SCL > + - 2 # ATMEL_MXT_WAKEUP_GPIO So you can add: minimum: 0 maximum: 2 I suppose? With that: Reviewed-by: Linus Walleij Yours, Linus Walleij