From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D2EC6FD18 for ; Wed, 29 Mar 2023 08:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbjC2Ina (ORCPT ); Wed, 29 Mar 2023 04:43:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbjC2In2 (ORCPT ); Wed, 29 Mar 2023 04:43:28 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E73A4489 for ; Wed, 29 Mar 2023 01:43:22 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id y5so18386680ybu.3 for ; Wed, 29 Mar 2023 01:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680079402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9QFNGRe/qYkwzP+fiwIAdq/5V8K+RvjLHPqES/KYnQs=; b=UDmPhRlclATqTR3oU+JfMUKUNxBedWAoB8uH9wvtpOHcmS2thP3SeN9cTKn0VrfinC BS8aWMdByHK3ANvXGd2TbQlSY1RSbYs8C4qXS5siAu6yyRHCHAHFcIIq23MGbsCzKcoi mT3iQwRdCgYU8h9r9wbqAJB1xUG/cmFX1q6mNsztoypuLTBFRdUXszJXIETSUJ7o8jh+ JbIBIU8BB+JH8Q/rSyf7YQLbzxN0dewYTF1QmUHP/Iq7dMk+z3hjTJg6X4V4swm21brD TSS58kMWeOue+lWNwqObAuSLfi/E1O5iQ8+/PZlpRaid+inys7UHTnBh+nbTOmTkssH/ lgKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680079402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9QFNGRe/qYkwzP+fiwIAdq/5V8K+RvjLHPqES/KYnQs=; b=F+TfJQfN43nAREcuJM0nhJRKfCn1kdDpTl9yjDs2vNcnl+QRNb+kk75ZJVL4FqZBd0 QfH1ltewmjVG82hs6UX+uHsJBJs0szLGmbMOdIlYpYv0VjcI2NRL8873PwU01hbWUIGQ 28hfLJHs52bVCAxeN5AOz3I3T4X9H/dALICisGqOg/YKE5oXL8KElsZZnIl1MLyfvuyG cA+5pOorashkluLT/hbGrOl+p5Pqkm4GqhQyncPuFzNKbaCWdCYsLy2g5tAe50+bsuzv GCayMa30yaxC+wFqixmVho9K3orqcuWvvaoyeVnW5x/ddeRKDCZdnaNWzawGrDlJfTdn C4/g== X-Gm-Message-State: AAQBX9fg50M0S+khKVdyIDpR/RjKs0U7yErEfsnOuw+zSG5Px+spdP5a 5ZdMq0laW+Q/CZbRztdxooLLJ9OCiIKYvOpvvNgI2A== X-Google-Smtp-Source: AKy350ZHBV4ak74c7b80acYJQ6Xgio8lk0wyiIDmxjNMY7qeC2l8+M1gaHWSfG/aRIjosaM0+ZWTR412sobwXSpNErM= X-Received: by 2002:a05:6902:1145:b0:b09:6f3d:ea1f with SMTP id p5-20020a056902114500b00b096f3dea1fmr11980914ybu.4.1680079402143; Wed, 29 Mar 2023 01:43:22 -0700 (PDT) MIME-Version: 1.0 References: <20230323135205.1160879-1-mweigand@mweigand.net> <20230323135205.1160879-4-mweigand@mweigand.net> In-Reply-To: <20230323135205.1160879-4-mweigand@mweigand.net> From: Linus Walleij Date: Wed, 29 Mar 2023 10:43:10 +0200 Message-ID: Subject: Re: [PATCH 3/6] devicetree: input: cypress,tt21000: fix interrupt type in dts example To: Maximilian Weigand Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alistair Francis Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Mar 23, 2023 at 2:52=E2=80=AFPM Maximilian Weigand wrote: > Triggering the interrupt of the IRQ_TYPE_LEVEL_LOW type can lead to > probing issues with the device for the current driver (encountered on > the Pine64 PineNote). Basically the interrupt would be triggered before > certain commands were sent to the device, leading to a race between the > device responding fast enough and the irq handler fetching a data frame > from it. Actually all devices currently using the driver already use a > falling edge trigger. > > Signed-off-by: Maximilian Weigand > Reviewed-by: Alistair Francis Reviewed-by: Linus Walleij Yours, Linus Walleij