From: Linus Walleij <linus.walleij@linaro.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support
Date: Wed, 6 May 2020 14:46:20 +0200 [thread overview]
Message-ID: <CACRpkdb3kG=7SQg8RGh1F=8=_mivV6p_zxpodFT=M-f3PmiyYQ@mail.gmail.com> (raw)
In-Reply-To: <BN6PR04MB0660B420EFA83668BBF4F315A3A90@BN6PR04MB0660.namprd04.prod.outlook.com>
On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker <xc-racer2@live.ca> wrote:
> The bma180 IIO driver has been extended for support for bma023.
> However, this could cause conflicts with this driver. Since some
> setups may depend upon the evdev setup, disable support in this
> driver for the bma023 only when the IIO driver is being built.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
I would just fix this with KConfig instead, like add mutually
exclusive depends on these two drivers.
Set this input driver as:
depends on BMA180=n
And the IIO driver as:
depends on INPUT_BMA150=n
It's a rough measure but this input driver should anyway
go away.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-05-06 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200503172206.13782-1-xc-racer2@live.ca>
2020-05-03 17:22 ` [PATCH 1/5] iio: accel: bma180: Prepare for different reset values Jonathan Bakker
2020-05-06 12:37 ` Linus Walleij
2020-05-03 17:22 ` [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support Jonathan Bakker
2020-05-06 12:46 ` Linus Walleij [this message]
2020-05-07 3:46 ` Jonathan Bakker
2020-05-07 4:23 ` Dmitry Torokhov
2020-05-08 15:57 ` Jonathan Bakker
2020-05-08 19:41 ` Linus Walleij
2020-05-03 17:22 ` [PATCH 3/5] dt-bindings: iio: accel: Add bma023 compatible to bma180 Jonathan Bakker
2020-05-06 12:49 ` Linus Walleij
2020-05-12 22:15 ` Rob Herring
2020-05-03 17:22 ` [PATCH 4/5] dt-bindings: iio: accel: Add required regulators " Jonathan Bakker
2020-05-06 12:49 ` Linus Walleij
2020-05-12 22:15 ` Rob Herring
2020-05-03 17:22 ` [PATCH 5/5] iio: accel: bma180: Add support for bma023 Jonathan Bakker
2020-05-06 12:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb3kG=7SQg8RGh1F=8=_mivV6p_zxpodFT=M-f3PmiyYQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kstewart@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).