From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA40C4361B for ; Sat, 5 Dec 2020 23:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49E4B23131 for ; Sat, 5 Dec 2020 23:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbgLEXLf (ORCPT ); Sat, 5 Dec 2020 18:11:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgLEXLe (ORCPT ); Sat, 5 Dec 2020 18:11:34 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C20FC0613D1 for ; Sat, 5 Dec 2020 15:10:48 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id d20so12742187lfe.11 for ; Sat, 05 Dec 2020 15:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1UEZz6HGFFmSdASHfwbCskijV7GUrzT+a+Yt9fsFZU=; b=QxPctIMns7UAHl7Ywu+Oy9o2xkI2GRvggQ/tyMeKeOu6xKfFq3kz1Vqes/lt7DLO28 75DJL3qYF1l2spY1c3NOw/DE4aeCnzH0tF/TsWY0m+9DGHVoCxtmgrWqbrfyvQvoA0Cp nICq/9VFHmU3pbgV77Rbikto/FeaOy3238t8+ECriapWRS5d5oVNEBuPdmVaxuSUq0QG UpA5BoAn6ZNsfyd6H0gPIUei4a8Aq0K4DZ1XTtF2AP7BN/1OZL10qZE3hUWTTDHvwnuz 2ISh7oLE/arJe3ZMldQB5CoUP1RcziZs1QMRzZR2NMmFjNDo2h4cp2T5e4TgkmrIbhCf pHpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1UEZz6HGFFmSdASHfwbCskijV7GUrzT+a+Yt9fsFZU=; b=C8x4ipX0xQWzJEtxTS6o7CPjjeldUXD99SHBoICZIwLMSONMIxwz/NZnavDw0nWn8V rvaPKgQbugDYTNNvCsIYtsSQ6tb+pMiuQMU7g10XKP+RYitJSTEdR+PpMNB8WCaZVKvl FeLLpk7AbRtucH6DEnRbCvh175uDFFN5Hh29RWMaXKcTFNvcu9vswRj4m8o6/mfGQN+z kOqEhQVjRC/4Dl+eBacWb8PiWovplbBdelz+2HbVQFKpjuAwaje7ta3bhtCtKP+wpjvo S1k9hvFbvAyfhXeIxSP3dFXQzgsxlWq1T6vw0IQlY+J4QlxjHSkVX+ZDKxJ3U7cGf+o6 Rk+A== X-Gm-Message-State: AOAM530In/TtY3+p/kWYXZJ0oXA3wYNMdacBn4ITVLQUdHB8d5AkrRrb fzfVQVP9Jv3AIel0oS1/bCeI1SnistJ04kvGcYv7kQ== X-Google-Smtp-Source: ABdhPJx6u5+LNHuD3eb5jh0scGEPapSyihps7xV7WYYMjWESuWf1iWHgbe3YuYsMsR1Wy+M4DYrGQC2NB28GRB/Sbf4= X-Received: by 2002:a19:8d8:: with SMTP id 207mr5324591lfi.441.1607209846988; Sat, 05 Dec 2020 15:10:46 -0800 (PST) MIME-Version: 1.0 References: <20201203131242.44397-1-stephan@gerhold.net> <20201203131242.44397-3-stephan@gerhold.net> In-Reply-To: <20201203131242.44397-3-stephan@gerhold.net> From: Linus Walleij Date: Sun, 6 Dec 2020 00:10:36 +0100 Message-ID: Subject: Re: [PATCH 3/3] Input: tm2-touchkey - add vddio regulator To: Stephan Gerhold Cc: Dmitry Torokhov , Linux Input , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Dec 3, 2020 at 2:13 PM Stephan Gerhold wrote: > The Samsung touchkey controllers are often used with external pull-up > for the interrupt line and the I2C lines, so we might need to enable > a regulator to bring the lines into usable state. Otherwise, this might > cause spurious interrupts and reading from I2C will fail. > > Implement support for a "vddio-supply" that is enabled by the > tm2-touchkey driver so that the regulator gets enabled when needed. > > Cc: Linus Walleij > Signed-off-by: Stephan Gerhold Reviewed-by: Linus Walleij Yours, Linus Walleij