From: Doug Anderson <dianders@chromium.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Jiri Kosina" <jkosina@suse.cz>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Stephen Boyd" <swboyd@chromium.org>,
"Andrea Borgia" <andrea@borgia.bo.it>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Daniel Playfair Cal" <daniel.playfair.cal@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Guido Günther" <agx@sigxcpu.org>,
"Jiri Kosina" <jikos@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Max Krummenacher" <max.oss.09@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Pavel Balan" <admin@kryma.net>,
"Shawn Guo" <shawnguo@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>, "Will Deacon" <will@kernel.org>,
"Xiaofei Tan" <tanxiaofei@huawei.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p
Date: Fri, 15 Jan 2021 09:11:12 -0800 [thread overview]
Message-ID: <CAD=FV=VfikuXYH5uq=cqqFJzCPNv86tMto-vezne3mVe3dTbcA@mail.gmail.com> (raw)
In-Reply-To: <f3add027-d732-0846-fa54-b3c51430b152@redhat.com>
Hi,
On Fri, Jan 15, 2021 at 6:58 AM Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> > Thanks, but don't spend too much time on it, unless something really
> > jumps out. I'll debug that tomorrow. It's much easier with an actual
> > device than by just looking at the code.
> >
>
> Well, that's weird. Now suspend resume works reliably even with your
> series. It could just have been that the lid sensor was too close to a
> magnet or something like that. Though while testing the old version of
> i2c-hid, it was working... Such a mystery :)
Friggin magnets, how do those work? ;-)
I also managed to obtain remote access to a device with an ACPI
i2c-hid device and confirmed that suspend/resume was working and that
I saw no errors, though obviously I couldn't physically interact with
the device remotely. Hopefully that gives a tiny bit of extra
confidence that the series is OK...
> This allows to keep the powering ordering of the old i2c-hid module
> (power up before setting device wakeup capable), and simplify the
> not so obvious power_fixed field of struct i2c_hid_acpi.
>
> (I can also send it as a followup on the series if you prefer).
Squashed it into a v9 as well as a local variable rename that I
noticed while looking at the code with fresh eyes. My v9 also
incorporates the new Goodix timing that I self-commented about on v8.
Crossing fingers that it's all good now. :-)
-Doug
prev parent reply other threads:[~2021-01-15 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 22:24 [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 2/4] arm64: defconfig: Update config names for i2c-hid rejigger Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 3/4] dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core Douglas Anderson
2021-01-06 16:44 ` Doug Anderson
2021-01-06 1:35 ` [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Doug Anderson
2021-01-08 17:52 ` Benjamin Tissoires
2021-01-13 15:08 ` Benjamin Tissoires
2021-01-13 15:58 ` Doug Anderson
2021-01-13 19:35 ` Benjamin Tissoires
2021-01-15 14:58 ` Benjamin Tissoires
2021-01-15 17:11 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VfikuXYH5uq=cqqFJzCPNv86tMto-vezne3mVe3dTbcA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=Anson.Huang@nxp.com \
--cc=admin@kryma.net \
--cc=agx@sigxcpu.org \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.playfair.cal@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=max.oss.09@gmail.com \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=swboyd@chromium.org \
--cc=tanxiaofei@huawei.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).