From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E3EC433E6 for ; Fri, 15 Jan 2021 17:12:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 395852333E for ; Fri, 15 Jan 2021 17:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387515AbhAORMK (ORCPT ); Fri, 15 Jan 2021 12:12:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733262AbhAORMJ (ORCPT ); Fri, 15 Jan 2021 12:12:09 -0500 Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18E1CC061757 for ; Fri, 15 Jan 2021 09:11:29 -0800 (PST) Received: by mail-ua1-x92b.google.com with SMTP id t15so3121511ual.6 for ; Fri, 15 Jan 2021 09:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zr+usiajQbvXCJZeiaAQ7ZOJ3FmLL56sdTHwAb93MCM=; b=YUoXFs0RFlgOeIyrZijD+N1grI8gVMlfGS9AkiyjIwbdZy5Rv4lR2QQNWrEF/vTkln hQ6gcZkOry9+vQ2+RJuTyZEjOqbZMfyprQINzU0SP0iuCwg66PGVc9YnP1v5O4YhHlOC hIoEXrUwRl6VsOk2/vvfHU1qdc9OlSHcSN/Fc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zr+usiajQbvXCJZeiaAQ7ZOJ3FmLL56sdTHwAb93MCM=; b=lbWivtEYpIKQZ0mBHrMqGv2Waqi6WJuvetApsTeSlUFle+ajJ1ZJh53CvhuepJuChQ R4Ybigh2RD1kMH1LdOw/FLQaly7hhD4akzDxQZb2SBjh8UDH3n82FziErTJq80lvMVpt d1gJZnVwBxrHrXtCgcrNox9QMVDDKZdWrHENV53BZPC3DPLhVk6qEZRxndo9fwX3TAsU Y7W7uUqByc2+EZCZe+UsfjBbrNSLO0tDYZ0WKdEB+0dZ/i4gM+cETXyNjdasU4M4HVsr 8O0mEzbgw9CzaDyr6l7sQVh532m+q3GrwLoXCtaw+fV80B0CERID1nXrx7JzAf9G+U4J uxwg== X-Gm-Message-State: AOAM530K3tMtQvLGG66kw3pMi/D1n5dE+bhhTDu6uz7kadmgbSY8FPLJ YCv2nvrbHb6dfZ/UXbRIAMEiYHLCjMSDsw== X-Google-Smtp-Source: ABdhPJyAbcb5nPr7uxUkBIE0GPP2DvqLVOR8HIDAQqUeJzD969xolxR+1pRKSbHxMZjlBOLLI/SkOg== X-Received: by 2002:ab0:2a4d:: with SMTP id p13mr10701458uar.18.1610730687936; Fri, 15 Jan 2021 09:11:27 -0800 (PST) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com. [209.85.217.45]) by smtp.gmail.com with ESMTPSA id b23sm1183513vso.34.2021.01.15.09.11.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 09:11:26 -0800 (PST) Received: by mail-vs1-f45.google.com with SMTP id e15so5413243vsa.0 for ; Fri, 15 Jan 2021 09:11:25 -0800 (PST) X-Received: by 2002:a67:70c6:: with SMTP id l189mr10887922vsc.34.1610730685365; Fri, 15 Jan 2021 09:11:25 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> In-Reply-To: From: Doug Anderson Date: Fri, 15 Jan 2021 09:11:12 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p To: Benjamin Tissoires Cc: Jiri Kosina , Greg Kroah-Hartman , Dmitry Torokhov , Hans de Goede , "open list:HID CORE LAYER" , Kai-Heng Feng , Rob Herring , Stephen Boyd , Andrea Borgia , Anson Huang , Bjorn Andersson , Catalin Marinas , Daniel Playfair Cal , Geert Uytterhoeven , =?UTF-8?Q?Guido_G=C3=BCnther?= , Jiri Kosina , Li Yang , Masahiro Yamada , Max Krummenacher , Michael Walle , Pavel Balan , Shawn Guo , Vinod Koul , Will Deacon , Xiaofei Tan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On Fri, Jan 15, 2021 at 6:58 AM Benjamin Tissoires wrote: > > > Thanks, but don't spend too much time on it, unless something really > > jumps out. I'll debug that tomorrow. It's much easier with an actual > > device than by just looking at the code. > > > > Well, that's weird. Now suspend resume works reliably even with your > series. It could just have been that the lid sensor was too close to a > magnet or something like that. Though while testing the old version of > i2c-hid, it was working... Such a mystery :) Friggin magnets, how do those work? ;-) I also managed to obtain remote access to a device with an ACPI i2c-hid device and confirmed that suspend/resume was working and that I saw no errors, though obviously I couldn't physically interact with the device remotely. Hopefully that gives a tiny bit of extra confidence that the series is OK... > This allows to keep the powering ordering of the old i2c-hid module > (power up before setting device wakeup capable), and simplify the > not so obvious power_fixed field of struct i2c_hid_acpi. > > (I can also send it as a followup on the series if you prefer). Squashed it into a v9 as well as a local variable rename that I noticed while looking at the code with fresh eyes. My v9 also incorporates the new Goodix timing that I self-commented about on v8. Crossing fingers that it's all good now. :-) -Doug