From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581A7C433E6 for ; Wed, 13 Jan 2021 16:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E33223433 for ; Wed, 13 Jan 2021 16:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726113AbhAMP7x (ORCPT ); Wed, 13 Jan 2021 10:59:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbhAMP7x (ORCPT ); Wed, 13 Jan 2021 10:59:53 -0500 Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7A0C061575 for ; Wed, 13 Jan 2021 07:59:13 -0800 (PST) Received: by mail-vs1-xe36.google.com with SMTP id x26so1389039vsq.1 for ; Wed, 13 Jan 2021 07:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2ptsf9Fb5Tne+PYknviL4oiSExm6FmhPbuzlfvggfPs=; b=gUvltVnFEhq+yEU1dS/TKI49xYRnCSvL5iotOLzopSdR8vpA9LrULAyFna01i39oq8 Unl+MY4DeY4yUagBcAkKBozOfmVBGo5jFvGF/aow2StUxh67DqtvxybTv/2qJNyZI/+A j33bfPZCU4le8vObXmjj2GnRedXENKq4btJ3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2ptsf9Fb5Tne+PYknviL4oiSExm6FmhPbuzlfvggfPs=; b=lPnk707gb/eSqxOtSTiMVpYtmuzhTAVLwqlAGDZlmCDZtuLFiaNfMPo9Q2O1eTeITL Q/bxDmzbULJort+HVoCw4Pb5O+vF4jMZlsv90gEgu6qggFG5A3Q21YP9W8AYHWG09Qlt Ef4FK99109IZi/5FuO5kAkDknZ5cnYKN8fZf5173G8iaBtShhCC/C64WRKDQWFP8Jc8j 2mBVIg+j3QP5i8vTmBAQiGKJ4y3IfvMjLTF8maCNbYwmV6PPrVYTjFJZ9XntEEGFIYsn pJOoE0AWUCul1K7rCx6Fl5Iqweu9VD2CLkbx8T3iv/4eMSQX1LDwyJmAx78x2UPIpM4E PvIw== X-Gm-Message-State: AOAM531a+VMYh6PuStEdnnMp/fEWnYv0TrForUmzLz7ks36wTivd9W3U OU6+9KAQHr1VIkvX81SOGoL7JiyuUc3N+A== X-Google-Smtp-Source: ABdhPJwUl86grXGPL1oRetxwgY1NDrYFwSHz2q3F0JK1H0kPTu1cGcLhWSPadrAITaTve5YbTAg4dQ== X-Received: by 2002:a67:e409:: with SMTP id d9mr2753809vsf.52.1610553552052; Wed, 13 Jan 2021 07:59:12 -0800 (PST) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com. [209.85.217.48]) by smtp.gmail.com with ESMTPSA id b19sm279965vsq.18.2021.01.13.07.59.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jan 2021 07:59:09 -0800 (PST) Received: by mail-vs1-f48.google.com with SMTP id e15so1388450vsa.0 for ; Wed, 13 Jan 2021 07:59:08 -0800 (PST) X-Received: by 2002:a67:bd01:: with SMTP id y1mr2892268vsq.49.1610553548379; Wed, 13 Jan 2021 07:59:08 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> In-Reply-To: From: Doug Anderson Date: Wed, 13 Jan 2021 07:58:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p To: Benjamin Tissoires Cc: Jiri Kosina , Greg Kroah-Hartman , Dmitry Torokhov , Hans de Goede , "open list:HID CORE LAYER" , Kai-Heng Feng , Rob Herring , Stephen Boyd , Andrea Borgia , Anson Huang , Bjorn Andersson , Catalin Marinas , Daniel Playfair Cal , Geert Uytterhoeven , =?UTF-8?Q?Guido_G=C3=BCnther?= , Jiri Kosina , Li Yang , Masahiro Yamada , Max Krummenacher , Michael Walle , Pavel Balan , Shawn Guo , Vinod Koul , Will Deacon , Xiaofei Tan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires wrote: > > > I wanted to apply the series yesterday, but for these kinds of changes > > I like giving it a spin on actual hardware. Turns out that my XPS-13 > > can not boot to v5.11-rc2, which makes testing the new branch slightly > > more difficult. > > > > I'll give it a spin next week, but I think I should be able to land it for 5.12. > > > > Regarding the defconfig conflict, no worries, we can handle it with > > Stephen and Linus. > > > > After 2 full kernel bisects (I messed up the first because I am an > idiot and inverted good and bad after the first reboot), I found my > culprit, and I was able to test the series today. > > The series works fine regarding enumeration and removing of devices, > but it prevents my system from being suspended. If I rmmod > i2c-hid-acpi, suspend works fine, but if it is present, it immediately > comes back, which makes me think that something must be wrong. > > I also just reverted the series and confirmed that suspend/resume now > works, meaning that patch 1/4 needs to be checked. Can you give me any hints about what type of failure you're seeing? Any logs? I don't have an ACPI system to test with... Is there any chance that some type of userspace / udev rule is getting tripped up by the driver being renamed? We ran into something like this recently on Chrome OS where we had a tool that was hardcoded to look for "i2c-hid" and needed to be adapted to account for the new driver name. Often userspace tweaks with wakeup rules based on driver name... I'll go stare at the code now and see if anything jumps out. -Doug