linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	kbuild-all@lists.01.org, Hans de Goede <hdegoede@redhat.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	Andrea Borgia <andrea@borgia.bo.it>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: Re: [PATCH v7 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules
Date: Fri, 11 Dec 2020 14:24:06 -0800	[thread overview]
Message-ID: <CAD=FV=WHe7E1xMGLxv99deOHVO2oH0LUsPMvwchxL5r6sQ_V6Q@mail.gmail.com> (raw)
In-Reply-To: <202012120310.liZcXbuL-lkp@intel.com>

Hi,

On Fri, Dec 11, 2020 at 11:25 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Douglas,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on hid/for-next]
> [also build test WARNING on next-20201211]
> [cannot apply to jikos-trivial/for-next v5.10-rc7]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/HID-i2c-hid-Reorganize-to-allow-supporting-goodix-gt7375p/20201212-014239
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
> config: powerpc-allyesconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/5a371169c8cc2abb463e32db3a3fe60ea34efc87
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Douglas-Anderson/HID-i2c-hid-Reorganize-to-allow-supporting-goodix-gt7375p/20201212-014239
>         git checkout 5a371169c8cc2abb463e32db3a3fe60ea34efc87
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/hid/i2c-hid/i2c-hid-core.c:1050:5: warning: no previous prototype for 'i2c_hid_core_suspend' [-Wmissing-prototypes]
>     1050 | int i2c_hid_core_suspend(struct device *dev)
>          |     ^~~~~~~~~~~~~~~~~~~~
> >> drivers/hid/i2c-hid/i2c-hid-core.c:1084:5: warning: no previous prototype for 'i2c_hid_core_resume' [-Wmissing-prototypes]
>     1084 | int i2c_hid_core_resume(struct device *dev)
>          |     ^~~~~~~~~~~~~~~~~~~

Yup, that's definitely true.  At the risk of a little extra spam, I'll
spin a quick v8 making these static so it's ready to land.  I guess I
missed doing that when we stopped exporting them and my compiler
doesn't yell about this.

-Doug

  parent reply	other threads:[~2020-12-11 23:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 17:35 [PATCH v7 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Douglas Anderson
2020-12-11 17:35 ` [PATCH v7 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules Douglas Anderson
     [not found]   ` <202012120310.liZcXbuL-lkp@intel.com>
2020-12-11 22:24     ` Doug Anderson [this message]
2020-12-11 17:35 ` [PATCH v7 2/4] arm64: defconfig: Update config names for i2c-hid rejigger Douglas Anderson
2020-12-11 17:35 ` [PATCH v7 3/4] dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-12-11 17:35 ` [PATCH v7 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core Douglas Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=WHe7E1xMGLxv99deOHVO2oH0LUsPMvwchxL5r6sQ_V6Q@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=andrea@borgia.bo.it \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=kai.heng.feng@canonical.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH v7 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).