Linux Input Archive on lore.kernel.org
 help / color / Atom feed
From: Yariv <oigevald+kernel@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: PROBLEM: Apple external Trackpad event timestamps are jittery (regression)
Date: Sat, 23 May 2020 22:11:50 +0300
Message-ID: <CAEwx+Qr=nJ0tPcuHhjO4=Mw_OHr17QcqeqTvcEzgZ0EcoNc8GQ@mail.gmail.com> (raw)
In-Reply-To: <20200523183734.GC89269@dtor-ws>

Hi,

I omitted what looks unrelated, please let me know if you need other
details or the full content.
Also I wasn't sure how to find the relevant driver, so I pasted the
relevant dmesg snippets. If there is a more precise way to identify
the driver please let me know and I'll send the missing items.

Gen1:

dmesg

[   11.307056] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
[   11.307060] Bluetooth: HIDP socket layer initialized
[   11.310541] magicmouse 0005:05AC:030E.0005: unknown main item tag 0x0
[   11.310657] input: john’s Trackpad as
/devices/pci0000:00/0000:00:14.0/usb1/1-13/1-13:1.0/bluetooth/hci0/hci0:70/0005:05AC:030E.0005/input/input21
[   11.310776] magicmouse 0005:05AC:030E.0005: input,hidraw4:
BLUETOOTH HID v1.60 Mouse [john’s Trackpad] on 00:1a:7d:da:71:09

/proc/bus/input/devices

I: Bus=0005 Vendor=05ac Product=030e Version=0160
N: Name="john’s Trackpad"
P: Phys=00:1a:7d:da:71:09
S: Sysfs=/devices/pci0000:00/0000:00:14.0/usb1/1-13/1-13:1.0/bluetooth/hci0/hci0:70/0005:05AC:030E.0005/input/input21
U: Uniq=d0:a6:37:f2:c3:af
H: Handlers=mouse1 event21
B: PROP=5
B: EV=10001b
B: KEY=e520 10000 0 0 0 0
B: ABS=273800000000003
B: MSC=10

Gen2:

dmesg

[13777.762475] magicmouse 0005:004C:0265.0008: unknown main item tag 0x0
[13777.762721] input: Apple Inc. Magic Trackpad 2 as
/devices/pci0000:00/0000:00:14.0/usb1/1-13/1-13:1.0/bluetooth/hci0/hci0:65/0005:004C:0265.0008/input/input24
[13777.763419] magicmouse 0005:004C:0265.0008: input,hidraw5:
BLUETOOTH HID v1.00 Mouse [Julo’s Trackpad] on 00:1a:7d:da:71:09

/proc/bus/input/devices

I: Bus=0005 Vendor=004c Product=0265 Version=0100
N: Name="Apple Inc. Magic Trackpad 2"
P: Phys=00:1a:7d:da:71:09
S: Sysfs=/devices/pci0000:00/0000:00:14.0/usb1/1-13/1-13:1.0/bluetooth/hci0/hci0:65/0005:004C:0265.0008/input/input24
U: Uniq=04:4b:ed:ec:b3:9c
H: Handlers=mouse2 event22
B: PROP=5
B: EV=b
B: KEY=e520 10000 0 0 0 0
B: ABS=673810001000003

Best regards,
Yariv

On Sat, May 23, 2020 at 9:37 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi,
>
> On Fri, May 22, 2020 at 08:27:43AM +0300, Yariv wrote:
> >
> > Some things I noticed: Gen2 didn't send "BTN_TOOL_FINGER" events,
> > while Gen1 did, even though I did not press any button. Note that Gen1
> > still had correct timestamps before the regression, even though it
> > sent these events.
> >
> > Another difference (maybe it's the same one..): if you take a look at
> > the logs from my previous mail, you'll notice that Gen1 Trackpads
> > always send both SYN_REPORT (0) as well as SYN_REPORT (1), while 2nd
> > Gen Trackpads only sends SYN_REPORT (0).
>
> So it looks like for Gen1 touchpads we set autorepeat, and it is that
> autorepeat on BTN_TOOL_FINGER that gives what you consider jitter.
>
>   - evdev:
>     - [  0, 293648,   1, 325,       2] # EV_KEY / BTN_TOOL_FINGER           2
>     - [  0, 293648,   0,   0,       1] # ------------ SYN_REPORT (1) ---------- +1ms
>   - evdev:
>     - [  0, 303026,   3,  48,      88] # EV_ABS / ABS_MT_TOUCH_MAJOR       88 (-12)
>     - [  0, 303026,   3,  53,    -232] # EV_ABS / ABS_MT_POSITION_X      -232 (-22)
>     - [  0, 303026,   3,  54,     291] # EV_ABS / ABS_MT_POSITION_Y       291 (+60)
>     - [  0, 303026,   3,   0,    -232] # EV_ABS / ABS_X                  -232 (-22)
>     - [  0, 303026,   3,   1,     291] # EV_ABS / ABS_Y                   291 (+60)
>     - [  0, 303026,   0,   0,       0] # ------------ SYN_REPORT (0) ---------- +10ms
>
> Can you please tell me what drivers are used by the 2 trackpads when they
> are connected via Bluetooth? I think we should stop setting autorepeat in
> the driver that handles Gen 1.
>
> Also, can you post /proc/bus/input/devices?
>
> Thanks.
>
> --
> Dmitry

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11  6:18 Yariv
2020-05-11 20:11 ` Dmitry Torokhov
2020-05-12  5:19   ` Peter Hutterer
2020-05-12 19:54     ` Yariv
2020-05-22  5:27       ` Yariv
2020-05-23 18:37         ` Dmitry Torokhov
2020-05-23 19:11           ` Yariv [this message]
2020-05-23 21:18             ` Dmitry Torokhov
2020-05-24 11:36               ` Yariv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEwx+Qr=nJ0tPcuHhjO4=Mw_OHr17QcqeqTvcEzgZ0EcoNc8GQ@mail.gmail.com' \
    --to=oigevald+kernel@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git