From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alexander Larkin <avlarkin82@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-input@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Security Officers <security@kernel.org>,
Murray McAllister <murray.mcallister@gmail.com>
Subject: Re: [PATCH] Input: joydev - prevent potential write out of bounds in ioctl
Date: Mon, 21 Jun 2021 08:45:23 -0700 [thread overview]
Message-ID: <CAHk-=wjtK7XgQqTE_OyGV8uPX3d1RqUhTQO1D+Bk3wGEiea3Ow@mail.gmail.com> (raw)
In-Reply-To: <YNAitJfOpoBkFitU@google.com>
On Sun, Jun 20, 2021 at 10:25 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Yes, this makes sense to me and it is safe as joydev->keypam is
> guaranteed to be the right size.
>
> Are you going to reformat this and resend or should I?
I don't have any hardware to test, so please consider that patch of
mine more of a "I think something like this" rather than a real patch
submission.
(I often find it easier to make a patch as a way to just make it very
explicit what I think might be the solution, rather than just
explaining it in English).
So please consider that patch throw-away - it's already gone from my tree.
And I don't need authorship for it: finding the problem - like
Alexander did - or even just writing a good commit message is worth
more than the patch itself, I think. The fix is a one-liner thing, the
real work was finding the bug.
So if you do want to set me as author, you can add my sign-off, but
you can just give credit to Alexander where it really belongs.
Linus
next prev parent reply other threads:[~2021-06-21 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 12:00 [PATCH] Input: joydev - prevent potential write out of bounds in ioctl Alexander Larkin
2021-06-20 16:37 ` Linus Torvalds
2021-06-21 5:25 ` Dmitry Torokhov
2021-06-21 15:45 ` Linus Torvalds [this message]
2021-06-21 20:06 ` Alexander Larkin
2021-06-21 21:30 ` Alexander Larkin
2021-06-21 21:32 ` Alexander Larkin
2021-06-21 22:38 ` Dmitry Torokhov
2021-07-03 16:21 ` Denis Efremov
2021-07-05 10:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjtK7XgQqTE_OyGV8uPX3d1RqUhTQO1D+Bk3wGEiea3Ow@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=avlarkin82@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murray.mcallister@gmail.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).