From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E24C433DF for ; Thu, 27 Aug 2020 09:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A41D20738 for ; Thu, 27 Aug 2020 09:05:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oQ4JwYQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbgH0JFl (ORCPT ); Thu, 27 Aug 2020 05:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726266AbgH0JFl (ORCPT ); Thu, 27 Aug 2020 05:05:41 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D2AC061264; Thu, 27 Aug 2020 02:05:41 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id v15so2897766pgh.6; Thu, 27 Aug 2020 02:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0LgS/funI+yMH3Misf/qyEZTDkijoEmJUp2sJjP9Ags=; b=oQ4JwYQl4GlrPXDLPASnT9mLJTD9FwiUcF2T2Pxu1ytAQhJ9e4yziNQif+ofQMrBMF hRgz2tchSkMv7NggEs2do17415JgNslbCP+8upd7Rp8ocFvjMORZLcgzosaZU2CnziCs UyalgPvWNX2Bu/1f7Dnpbtcji3ytVC/8jC9wln3biPvqXm0lzpvqqbhZqxF2KsqManmH Ewz0yIfwfc9fVKVr8tRQela+oySiB+1YPv3EUMIwFIxFgIsS0syykKVL/FprjkBEsinB fVakVTSm6Ev3O5VH3tmBSZFYpFy6E29GbHEySfnMB8ryicrQh1SbVyInXRgGNuQsQfHh NG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0LgS/funI+yMH3Misf/qyEZTDkijoEmJUp2sJjP9Ags=; b=EKVpC1zrv274r/xQmLe3DbJlsUouBsFuuacG6N9kLSrPr1h6iiBhIB2axUVRHpprrq nO3dx4f4Xy4PsujIwztizwcQEbeL2sKMQQYO9ACsr4wPgwaeonctrrgsdfeeHhMV7cxz Sz/5uzDptDr1iQSqftA/InwA2Wj676vM9em4E9lwOW6kwu+Y1IttsczlKZko0/WBswQJ XxYE/o/bKVJcWRqkmoUTIkZsRVqjKokz+fHl9fuaOZ2DkPMWaadWbwmMabivivYe2tzK iI+l4LLfeLfUjq9yfnJLe8RtlGY9Qrix2dbBYyySODty4bkw7eoKbJZqsBhj0o2hBPjK WwqA== X-Gm-Message-State: AOAM532ndcAI2YbdWxk/CzjHTsVExgScMJGxJi90U5d+q9AIcTmrBrUX 0XhcVpgByda5zeTTIjBTr63buJNrE3yqwM/deOM= X-Google-Smtp-Source: ABdhPJzxMe5xIFO/xzxVR2b2KBHEfiCygx9iaaGDGOcMk7dug7/eSxMXYmeXEtGbBmXV3CWIPxHnL6zH4003ZTvEiJM= X-Received: by 2002:a17:902:b194:: with SMTP id s20mr15688764plr.321.1598519140722; Thu, 27 Aug 2020 02:05:40 -0700 (PDT) MIME-Version: 1.0 References: <20200826181706.11098-1-krzk@kernel.org> <20200826181706.11098-3-krzk@kernel.org> In-Reply-To: <20200826181706.11098-3-krzk@kernel.org> From: Andy Shevchenko Date: Thu, 27 Aug 2020 12:05:24 +0300 Message-ID: Subject: Re: [PATCH 03/24] Input: gpio_keys_polled - Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , "Gustavo A. R. Silva" , Andy Shevchenko , linux-input , Linux Kernel Mailing List , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Aug 26, 2020 at 9:18 PM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > Reviewed-by: Andy Shevchenko > Signed-off-by: Krzysztof Kozlowski > --- > drivers/input/keyboard/gpio_keys_polled.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c > index c3937d2fc744..ba00ecfbd343 100644 > --- a/drivers/input/keyboard/gpio_keys_polled.c > +++ b/drivers/input/keyboard/gpio_keys_polled.c > @@ -299,13 +299,9 @@ static int gpio_keys_polled_probe(struct platform_device *pdev) > NULL, GPIOD_IN, > button->desc); > if (IS_ERR(bdata->gpiod)) { > - error = PTR_ERR(bdata->gpiod); > - if (error != -EPROBE_DEFER) > - dev_err(dev, > - "failed to get gpio: %d\n", > - error); > fwnode_handle_put(child); > - return error; > + return dev_err_probe(dev, PTR_ERR(bdata->gpiod), > + "failed to get gpio\n"); > } > } else if (gpio_is_valid(button->gpio)) { > /* > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko