* [PATCH v1 1/1] HID: i2c-hid: acpi: Move GUID out of function and described it
@ 2021-02-26 18:25 Andy Shevchenko
2021-02-26 18:45 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-02-26 18:25 UTC (permalink / raw)
To: Douglas Anderson, Andy Shevchenko, linux-input, linux-kernel
Cc: Jiri Kosina, Benjamin Tissoires
Move static GUID variable out of the function and add a comment
how it looks like in the human readable representation.
While at it, include uuid.h since the guid_t type is defined in it.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hid/i2c-hid/i2c-hid-acpi.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-acpi.c b/drivers/hid/i2c-hid/i2c-hid-acpi.c
index bb8c00e6be78..00bbd218f1e8 100644
--- a/drivers/hid/i2c-hid/i2c-hid-acpi.c
+++ b/drivers/hid/i2c-hid/i2c-hid-acpi.c
@@ -25,6 +25,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pm.h>
+#include <linux/uuid.h>
#include "i2c-hid.h"
@@ -42,11 +43,13 @@ static const struct acpi_device_id i2c_hid_acpi_blacklist[] = {
{ },
};
+/* HID I²C Device: 3cdff6f7-4267-4555-ad05-b30a3d8938de */
+static guid_t i2c_hid_guid =
+ GUID_INIT(0x3CDFF6F7, 0x4267, 0x4555,
+ 0xAD, 0x05, 0xB3, 0x0A, 0x3D, 0x89, 0x38, 0xDE);
+
static int i2c_hid_acpi_get_descriptor(struct i2c_client *client)
{
- static guid_t i2c_hid_guid =
- GUID_INIT(0x3CDFF6F7, 0x4267, 0x4555,
- 0xAD, 0x05, 0xB3, 0x0A, 0x3D, 0x89, 0x38, 0xDE);
union acpi_object *obj;
struct acpi_device *adev;
acpi_handle handle;
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] HID: i2c-hid: acpi: Move GUID out of function and described it
2021-02-26 18:25 [PATCH v1 1/1] HID: i2c-hid: acpi: Move GUID out of function and described it Andy Shevchenko
@ 2021-02-26 18:45 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-02-26 18:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Douglas Anderson, linux-input, Linux Kernel Mailing List,
Jiri Kosina, Benjamin Tissoires
On Fri, Feb 26, 2021 at 8:32 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Move static GUID variable out of the function and add a comment
> how it looks like in the human readable representation.
>
> While at it, include uuid.h since the guid_t type is defined in it.
Oh, I see more improvements can be done, so, I will send this and the
rest as v2 altogether.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-26 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 18:25 [PATCH v1 1/1] HID: i2c-hid: acpi: Move GUID out of function and described it Andy Shevchenko
2021-02-26 18:45 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).