From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Fengping yu <fengping.yu@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
linux-input <linux-input@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v15 2/3] drivers: input:keyboard: Add mtk keypad driver
Date: Tue, 21 Jul 2020 17:23:03 +0300 [thread overview]
Message-ID: <CAHp75VcnfF3ucuAJXDDy8pit5-LE42d4ROkL2y3QZroK6RU4Rw@mail.gmail.com> (raw)
In-Reply-To: <87ft9l3v2l.fsf@baylibre.com>
On Tue, Jul 21, 2020 at 3:38 PM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
> Fengping yu <fengping.yu@mediatek.com> writes:
> > This adds matrix keypad support for Mediatek SoCs.
...
> > + keypad->regmap = devm_regmap_init_mmio(&pdev->dev,
> > + keypad->base,
> > + &keypad_regmap_cfg);
> > + if (IS_ERR(keypad->regmap)) {
> > + dev_err(&pdev->dev,
> > + "regmap init failed:%ld\n", PTR_ERR(keypad->regmap));
> > + return PTR_ERR(keypad->regmap);
> > + }
Okay, because another comment appeared, I would suggest to switch to
%pe at the same time.
dev_err(&pdev->dev, "regmap init failed: %pe\n", keypad->regmap);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-21 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 2:23 [PATCH v15] Add matrix keypad driver support Mediatek SoCs Fengping yu
[not found] ` <20200721022324.21898-3-fengping.yu@mediatek.com>
2020-07-21 12:34 ` [PATCH v15 2/3] drivers: input:keyboard: Add mtk keypad driver Mattijs Korpershoek
2020-07-21 14:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcnfF3ucuAJXDDy8pit5-LE42d4ROkL2y3QZroK6RU4Rw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=mkorpershoek@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).