From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D096C433E1 for ; Thu, 27 Aug 2020 09:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4141822B4D for ; Thu, 27 Aug 2020 09:20:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gcovqugj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbgH0JUU (ORCPT ); Thu, 27 Aug 2020 05:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726266AbgH0JUS (ORCPT ); Thu, 27 Aug 2020 05:20:18 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C22D9C061264; Thu, 27 Aug 2020 02:20:16 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 17so3025297pfw.9; Thu, 27 Aug 2020 02:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NHovxXj8kNl+bO/iYwws9eniGeyDYn/VL5TU+ffgVe8=; b=gcovqugjmSAGtw1SadGUSYghzOegMGsxuFFYTfl1i1TQhmAUH6wYXgJf7oDOSnUiYo 2yK4hr+IonNH5Z4kS3bkZcB88gD+xw0D6GNM6JUhyWRNmy6MI1i9wwYK4XaTB4Akm4r2 J6MwACe7X9ZN1B3YkRf/ZoOc+gQ8RcuO5ykz5nxUqZEdYDq4LorwFP8/tJCrOBQI5hj2 R5Xspmoa60AUW0Wiv4zZXY758AhK/RnvcF4AYPOgUHrjr82+/2ol7b/YWwMvLwKp5UNo CNkKggy9+VmOWdL7LdYqeEjDNe8GO21LhokpW8WeEIsQAst4GEgETw4DS+N39sBYcsI5 dPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NHovxXj8kNl+bO/iYwws9eniGeyDYn/VL5TU+ffgVe8=; b=PbBtLHgOx4DtoVBrAhx5UMoPzHIsiXSjwbFg72i4OVYggKN5QfbdhLjJjmHByvkA3w gjEVN5UWUXG1g5PKePxKihy+qX4MmQR/2BoyVaZxmOn2ZFFvJLqFI0ou0Yk6cCdyqHwb GRtYMzfB837yy94/8Zz1K+5Bp8QfGo9oM5+oWy5cJnyd6pm1mIxLEZplYqlziYNpoIsW z9CHvMLE5P/zBQ6GRzGl5c515mmfRQzzDACqndmKQAzD40xBy8rydsJ9NSL54WdMhKh3 GkWjBwhxF82loJCGw1arbU+DnpsaHC26pGcqYmIJBveXpdngnV3Hk6ctzCMGDvJXByFI wDJQ== X-Gm-Message-State: AOAM530UNccRgCioGGCjRa0vYyy9f2L7hhDtjXWqOk9AXdpzNF6RqBwX rZamouAe5+ymw8HqnvyBXdpQ2dQq9jVz64MC52M= X-Google-Smtp-Source: ABdhPJwe0B4oPJaBrE/zcyPdEd/iXNQmz7ydwrDHQeDooT4rtlP2BEsxoIKXfXOd3ZfQIEmpnRfN8FY78P1J1rOzibo= X-Received: by 2002:a63:ec18:: with SMTP id j24mr13402591pgh.74.1598520016226; Thu, 27 Aug 2020 02:20:16 -0700 (PDT) MIME-Version: 1.0 References: <20200826181706.11098-1-krzk@kernel.org> <20200826181706.11098-24-krzk@kernel.org> In-Reply-To: <20200826181706.11098-24-krzk@kernel.org> From: Andy Shevchenko Date: Thu, 27 Aug 2020 12:20:00 +0300 Message-ID: Subject: Re: [PATCH 24/24] Input: sx8643 - Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , "Gustavo A. R. Silva" , Andy Shevchenko , linux-input , Linux Kernel Mailing List , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Aug 26, 2020 at 9:21 PM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. Reviewed-by: Andy Shevchenko Just in case if you want to save more LOCs, you may in some drivers introduce temporary variable for device pointer, like struct device *dev = &client->dev; > Signed-off-by: Krzysztof Kozlowski > --- > drivers/input/touchscreen/sx8654.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c > index de85e57b2486..d2ed9be64c3a 100644 > --- a/drivers/input/touchscreen/sx8654.c > +++ b/drivers/input/touchscreen/sx8654.c > @@ -323,13 +323,9 @@ static int sx8654_probe(struct i2c_client *client, > > sx8654->gpio_reset = devm_gpiod_get_optional(&client->dev, "reset", > GPIOD_OUT_HIGH); > - if (IS_ERR(sx8654->gpio_reset)) { > - error = PTR_ERR(sx8654->gpio_reset); > - if (error != -EPROBE_DEFER) > - dev_err(&client->dev, "unable to get reset-gpio: %d\n", > - error); > - return error; > - } > + if (IS_ERR(sx8654->gpio_reset)) > + return dev_err_probe(&client->dev, PTR_ERR(sx8654->gpio_reset), > + "unable to get reset-gpio\n"); > dev_dbg(&client->dev, "got GPIO reset pin\n"); > > sx8654->data = device_get_match_data(&client->dev); > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko