From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Orlando Chamberlain <orlandoch.dev@gmail.com>
Cc: linux-input@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Pavel Machek" <pavel@ucw.cz>,
"Aditya Garg" <gargaditya08@live.com>,
"Aun-Ali Zaidi" <admin@kodeit.net>,
"Kerem Karabay" <kekrby@gmail.com>,
"Andy Shevchenko" <andy@infradead.org>,
"Thomas Weißschuh" <thomas@t-8ch.de>
Subject: Re: [PATCH 2/2] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards
Date: Thu, 16 Feb 2023 13:49:21 +0200 [thread overview]
Message-ID: <CAHp75VeX0j8ZX+j0i7qPe97NcyFLvhmETFCbRVYiVCFQWk8Akg@mail.gmail.com> (raw)
In-Reply-To: <20230216181050.52a31247@redecorated-mbp>
On Thu, Feb 16, 2023 at 10:15 AM Orlando Chamberlain
<orlandoch.dev@gmail.com> wrote:
> On Thu, 16 Feb 2023 15:12:28 +1100
> Orlando Chamberlain <orlandoch.dev@gmail.com> wrote:
...
> > drivers/hid/apple-magic-backlight.c | 125
>
> A general question to the hid/input folks:
>
> Is it alright that this doesn't start with "hid-"? All the other
> drivers start with that so I'm not sure if its an issue.
What makes apple so special?
> If it is, then
> I can rename it to "hid-apple-magic-backlight".
If there is a good justification of not doing that, put it into the
commit message.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-02-16 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 4:12 [PATCHv2 0/2] Apple Magic Keyboard Backlight Orlando Chamberlain
2023-02-16 4:12 ` [PATCH 1/2] Documentation: leds: standardise keyboard backlight led names Orlando Chamberlain
2023-02-16 4:12 ` [PATCH 2/2] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards Orlando Chamberlain
2023-02-16 5:41 ` Thomas Weißschuh
2023-02-16 5:58 ` Orlando Chamberlain
2023-02-16 11:51 ` Andy Shevchenko
2023-02-16 7:10 ` Orlando Chamberlain
2023-02-16 11:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeX0j8ZX+j0i7qPe97NcyFLvhmETFCbRVYiVCFQWk8Akg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=admin@kodeit.net \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=corbet@lwn.net \
--cc=gargaditya08@live.com \
--cc=jikos@kernel.org \
--cc=kekrby@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orlandoch.dev@gmail.com \
--cc=pavel@ucw.cz \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).