linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
@ 2020-05-12 20:40 Bernhard Übelacker
  2020-05-12 20:44 ` Hans de Goede
  0 siblings, 1 reply; 8+ messages in thread
From: Bernhard Übelacker @ 2020-05-12 20:40 UTC (permalink / raw)
  To: Hans de Goede, Darren Hart, Andy Shevchenko, linux-input,
	platform-driver-x86, linux-kernel
  Cc: Bernhard Übelacker, Otmar Meier

Add touchscreen info for the Trekstor Yourbook C11B. It seems to
use the same touchscreen as the Primebook C11, so we only add a new DMI
match.

Cc: Otmar Meier <otmarjun.meier@nexgo.de>
Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
---
 drivers/platform/x86/touchscreen_dmi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 6ec8923dec1a..d87315892458 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -1106,6 +1106,14 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_BIOS_VERSION, "TREK.G.WI71C.JGBMRBA05"),
 		},
 	},
+	{
+		/* Trekstor Yourbook C11B (same touchscreen as the Primebook C11) */
+		.driver_data = (void *)&trekstor_primebook_c11_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "YOURBOOK C11B"),
+		},
+	},
 	{
 		/* Yours Y8W81, same case and touchscreen as Chuwi Vi8 */
 		.driver_data = (void *)&chuwi_vi8_data,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-12 20:40 [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B Bernhard Übelacker
@ 2020-05-12 20:44 ` Hans de Goede
  2020-05-12 20:51   ` Andy Shevchenko
  2020-05-13 17:17   ` Andy Shevchenko
  0 siblings, 2 replies; 8+ messages in thread
From: Hans de Goede @ 2020-05-12 20:44 UTC (permalink / raw)
  To: Bernhard Übelacker, Darren Hart, Andy Shevchenko,
	linux-input, platform-driver-x86, linux-kernel
  Cc: Otmar Meier

Hi,

On 5/12/20 10:40 PM, Bernhard Übelacker wrote:
> Add touchscreen info for the Trekstor Yourbook C11B. It seems to
> use the same touchscreen as the Primebook C11, so we only add a new DMI
> match.
> 
> Cc: Otmar Meier <otmarjun.meier@nexgo.de>
> Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
> Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>

Thank you, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/platform/x86/touchscreen_dmi.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 6ec8923dec1a..d87315892458 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -1106,6 +1106,14 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
>   			DMI_MATCH(DMI_BIOS_VERSION, "TREK.G.WI71C.JGBMRBA05"),
>   		},
>   	},
> +	{
> +		/* Trekstor Yourbook C11B (same touchscreen as the Primebook C11) */
> +		.driver_data = (void *)&trekstor_primebook_c11_data,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "YOURBOOK C11B"),
> +		},
> +	},
>   	{
>   		/* Yours Y8W81, same case and touchscreen as Chuwi Vi8 */
>   		.driver_data = (void *)&chuwi_vi8_data,
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-12 20:44 ` Hans de Goede
@ 2020-05-12 20:51   ` Andy Shevchenko
  2020-05-12 20:57     ` Andy Shevchenko
  2020-05-13 17:17   ` Andy Shevchenko
  1 sibling, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2020-05-12 20:51 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Bernhard Übelacker, Darren Hart, Andy Shevchenko,
	linux-input, Platform Driver, Linux Kernel Mailing List,
	Otmar Meier

On Tue, May 12, 2020 at 11:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 5/12/20 10:40 PM, Bernhard Übelacker wrote:
> > Add touchscreen info for the Trekstor Yourbook C11B. It seems to
> > use the same touchscreen as the Primebook C11, so we only add a new DMI
> > match.
> >
> > Cc: Otmar Meier <otmarjun.meier@nexgo.de>
> > Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
> > Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
>
> Thank you, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

I don't see it neither in our patchwork nor in Linux Input...

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-12 20:51   ` Andy Shevchenko
@ 2020-05-12 20:57     ` Andy Shevchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2020-05-12 20:57 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Bernhard Übelacker, Darren Hart, Andy Shevchenko,
	linux-input, Platform Driver, Linux Kernel Mailing List,
	Otmar Meier

On Tue, May 12, 2020 at 11:51 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, May 12, 2020 at 11:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
> > On 5/12/20 10:40 PM, Bernhard Übelacker wrote:

> I don't see it neither in our patchwork nor in Linux Input...

Okay, no worries, it came at last.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-12 20:44 ` Hans de Goede
  2020-05-12 20:51   ` Andy Shevchenko
@ 2020-05-13 17:17   ` Andy Shevchenko
  2020-05-15 14:07     ` Bernhard Übelacker
  1 sibling, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2020-05-13 17:17 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Bernhard Übelacker, Darren Hart, Andy Shevchenko,
	linux-input, Platform Driver, Linux Kernel Mailing List,
	Otmar Meier

On Tue, May 12, 2020 at 11:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 5/12/20 10:40 PM, Bernhard Übelacker wrote:
> > Add touchscreen info for the Trekstor Yourbook C11B. It seems to
> > use the same touchscreen as the Primebook C11, so we only add a new DMI
> > match.
> >
> > Cc: Otmar Meier <otmarjun.meier@nexgo.de>
> > Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
> > Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
>
> Thank you, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

This doesn't apply to our for-next.
Please, rebase, add Hans' tag and resend, thanks!

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-13 17:17   ` Andy Shevchenko
@ 2020-05-15 14:07     ` Bernhard Übelacker
  2020-05-15 14:18       ` Andy Shevchenko
  0 siblings, 1 reply; 8+ messages in thread
From: Bernhard Übelacker @ 2020-05-15 14:07 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Hans de Goede, Darren Hart, Andy Shevchenko, linux-input,
	Platform Driver, Linux Kernel Mailing List, Otmar Meier


Am 13.05.20 um 19:17 schrieb Andy Shevchenko:
> On Tue, May 12, 2020 at 11:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>> On 5/12/20 10:40 PM, Bernhard Übelacker wrote:
>>> Add touchscreen info for the Trekstor Yourbook C11B. It seems to
>>> use the same touchscreen as the Primebook C11, so we only add a new DMI
>>> match.
>>>
>>> Cc: Otmar Meier <otmarjun.meier@nexgo.de>
>>> Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
>>> Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
>>
>> Thank you, patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> This doesn't apply to our for-next.
> Please, rebase, add Hans' tag and resend, thanks!


Hello Andy,
I am not sure against which git tree I should rebase?

I tried to rebase against the branch for-next in the git tree below.
And tried to apply the patch saved from my
thunderbird and got no error.

Is this the right git tree?

Kind regards,
Bernhard


$ git clone -b for-next --single-branch --depth=10000  git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git
$ cd linux-gpio-intel
$ LANG=C git am ../'[PATCH] platform_x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B.eml'
Applying: platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-15 14:07     ` Bernhard Übelacker
@ 2020-05-15 14:18       ` Andy Shevchenko
  2020-05-15 15:59         ` [PATCH v2] " Bernhard Übelacker
  0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2020-05-15 14:18 UTC (permalink / raw)
  To: Bernhard Übelacker
  Cc: Hans de Goede, Darren Hart, Andy Shevchenko, linux-input,
	Platform Driver, Linux Kernel Mailing List, Otmar Meier

On Fri, May 15, 2020 at 5:08 PM Bernhard Übelacker
<bernhardu@mailbox.org> wrote:
> Am 13.05.20 um 19:17 schrieb Andy Shevchenko:
> > On Tue, May 12, 2020 at 11:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >> Hi,
> >> On 5/12/20 10:40 PM, Bernhard Übelacker wrote:
> >>> Add touchscreen info for the Trekstor Yourbook C11B. It seems to
> >>> use the same touchscreen as the Primebook C11, so we only add a new DMI
> >>> match.
> >>>
> >>> Cc: Otmar Meier <otmarjun.meier@nexgo.de>
> >>> Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
> >>> Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
> >>
> >> Thank you, patch looks good to me:
> >>
> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > This doesn't apply to our for-next.
> > Please, rebase, add Hans' tag and resend, thanks!

> I am not sure against which git tree I should rebase?

Ah, sorry, this one [1] you should use for PDx86.

[1]: http://git.infradead.org/linux-platform-drivers-x86.git

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B
  2020-05-15 14:18       ` Andy Shevchenko
@ 2020-05-15 15:59         ` Bernhard Übelacker
  0 siblings, 0 replies; 8+ messages in thread
From: Bernhard Übelacker @ 2020-05-15 15:59 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Hans de Goede, Darren Hart, linux-input, platform-driver-x86,
	linux-kernel, Bernhard Übelacker, Otmar Meier

Add touchscreen info for the Trekstor Yourbook C11B. It seems to
use the same touchscreen as the Primebook C11, so we only add a new DMI
match.

Cc: Otmar Meier <otmarjun.meier@nexgo.de>
Reported-and-tested-by: Otmar Meier <otmarjun.meier@nexgo.de>
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/touchscreen_dmi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 87591cea127a..f9d9045cdf40 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -1197,6 +1197,14 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_BIOS_VERSION, "TREK.G.WI71C.JGBMRBA05"),
 		},
 	},
+	{
+		/* Trekstor Yourbook C11B (same touchscreen as the Primebook C11) */
+		.driver_data = (void *)&trekstor_primebook_c11_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TREKSTOR"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "YOURBOOK C11B"),
+		},
+	},
 	{
 		/* Vinga Twizzle J116 */
 		.driver_data = (void *)&vinga_twizzle_j116_data,
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-05-15 16:01 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 20:40 [PATCH] platform/x86: touchscreen_dmi: Add info for the Trekstor Yourbook C11B Bernhard Übelacker
2020-05-12 20:44 ` Hans de Goede
2020-05-12 20:51   ` Andy Shevchenko
2020-05-12 20:57     ` Andy Shevchenko
2020-05-13 17:17   ` Andy Shevchenko
2020-05-15 14:07     ` Bernhard Übelacker
2020-05-15 14:18       ` Andy Shevchenko
2020-05-15 15:59         ` [PATCH v2] " Bernhard Übelacker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).