From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
Cc: Richard Neumann <mail@richard-neumann.de>,
Sandeep Singh <Sandeep.Singh@amd.com>,
Shyam-sundar.S-k@amd.com, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework
Date: Tue, 31 Mar 2020 20:24:59 +0300 [thread overview]
Message-ID: <CAHp75Vfr6q_H6z6tRFfaKedF7oR7nhmZvRWL4mxx3W7uypUFvA@mail.gmail.com> (raw)
In-Reply-To: <896f84bc-f0d6-59a5-c894-809695aa348f@amd.com>
On Tue, Mar 31, 2020 at 4:26 PM Shah, Nehal-bakulchandra
<nehal-bakulchandra.shah@amd.com> wrote:
> On 3/31/2020 6:01 PM, Richard Neumann wrote:
> > Not a real review, but your patch series seems to be repeating a lot
> > from drivers/i2c/busses/i2c-amd-mp2*.
> > Is there any chance we could re-use the code?
> > E.g. the AMD_C2P_* definitions from drivers/i2c/busses/i2c-amd-mp2.h?
>
> Thanks for the mail. Yes there are some common structures, however as of now we have kept separately considering both
>
> are part of different sub systems. But may be will consider this input for future enhancement.
It can be done in a form of shared definitions at least in
include/linux/platform_data/x86/amd-mp2.h or alike ...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-31 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 4:58 [PATCH v4 0/4] SFH: Add Support for AMD Sensor Fusion Hub Sandeep Singh
2020-02-27 4:58 ` [PATCH v4 1/4] SFH: Add maintainers and documentation for AMD SFH based on HID framework Sandeep Singh
2020-02-27 4:58 ` [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using " Sandeep Singh
2020-03-09 5:13 ` Singh, Sandeep
2020-03-27 14:55 ` Andy Shevchenko
2020-03-30 5:12 ` Singh, Sandeep
2020-03-30 8:33 ` Richard Neumann
2020-03-31 12:31 ` Richard Neumann
2020-03-31 13:18 ` Shah, Nehal-bakulchandra
2020-03-31 17:24 ` Andy Shevchenko [this message]
2020-04-01 16:28 ` Richard Neumann
2020-04-06 5:26 ` Shah, Nehal-bakulchandra
2020-04-13 13:33 ` Richard Neumann
2020-04-21 18:31 ` Shah, Nehal-bakulchandra
2020-04-21 21:18 ` Richard Neumann
2020-02-27 4:58 ` [PATCH v4 3/4] SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH) Sandeep Singh
2020-02-27 4:58 ` [PATCH v4 4/4] SFH: Create HID report to Enable support of AMD sensor fusion " Sandeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vfr6q_H6z6tRFfaKedF7oR7nhmZvRWL4mxx3W7uypUFvA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Sandeep.Singh@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@richard-neumann.de \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).