From: Dylan MacKenzie <ecstaticmorse@gmail.com>
To: jikos@kernel.org
Cc: Basavaraj.Natikar@amd.com, Nehal-Bakulchandra.shah@amd.com,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
shyam-sundar.s-k@amd.com
Subject: Re: [PATCH 0/3] Add SFH sensor support for newer AMD platforms
Date: Sat, 26 Jun 2021 16:34:21 -0700 [thread overview]
Message-ID: <CAHpHHjbnhAnhkq-G1UbtjP=SB24FVnEtsXqkT8_ZTb7UD8j_kA@mail.gmail.com> (raw)
> Now queued in for-5.14/amd-sfh. Thanks,
FYI, this patch still uses the wrong register in `amd_sensor_stop_v2`.
Basavaraj confirmed this, but my email client didn't CC the list for
that conversation. Whoops!
Also, I've tested this locally on an HP Envy x360 with a Ryzen 4700U
(Renoir) and it doesn't work even though the new code paths are taken.
My `activecontrolstatus`, the register containing the sensor mask
along with the newly checked hardware ID in the lower four bits, is
`0x002bdff2`. Just like before, three IIO devices are initialized, but
the first read from the DMA buffers returns a constant, garbage value,
and all subsequent reads return zeroes. I assume that this patch is
working on whatever hardware the OP is using to test. Should it be
working on all Renoir systems?
next reply other threads:[~2021-06-26 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 23:34 Dylan MacKenzie [this message]
2021-07-12 8:08 ` [PATCH 0/3] Add SFH sensor support for newer AMD platforms Jiri Kosina
2021-07-15 6:38 ` Basavaraj Natikar
-- strict thread matches above, loose matches on Subject: below --
2021-06-18 8:18 Basavaraj Natikar
2021-06-24 12:28 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHpHHjbnhAnhkq-G1UbtjP=SB24FVnEtsXqkT8_ZTb7UD8j_kA@mail.gmail.com' \
--to=ecstaticmorse@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Nehal-Bakulchandra.shah@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=shyam-sundar.s-k@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).