From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Raul E Rangel <rrangel@chromium.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Tim Van Patten <timvp@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
"jingle.wu" <jingle.wu@emc.com.tw>, Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 08/13] ACPI: PM: Take wake IRQ into consideration when entering suspend-to-idle
Date: Thu, 29 Sep 2022 21:06:56 +0200 [thread overview]
Message-ID: <CAJZ5v0ho2vwoUDk_CFRi3ztA8mz3pWWY1OqwLK4NdXrHSbKjmw@mail.gmail.com> (raw)
In-Reply-To: <20220929093200.v6.8.I7d9202463f08373feccd6e8fd87482c4f40ece5d@changeid>
On Thu, Sep 29, 2022 at 6:19 PM Raul E Rangel <rrangel@chromium.org> wrote:
>
> This change adds support for ACPI devices that use ExclusiveAndWake or
> SharedAndWake in their _CRS GpioInt definition (instead of using _PRW),
> and also provide power resources. Previously the ACPI subsystem had no
> idea if the device had a wake capable interrupt armed. This resulted
> in the ACPI device PM system placing the device into D3Cold, and thus
> cutting power to the device. With this change we will now query the
> _S0W method to figure out the appropriate wake capable D-state.
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> ---
>
> Changes in v6:
> - Refactored to leave else clause
>
> Changes in v5:
> - Go back to using adev->wakeup.flags.valid to keep the diff cleaner
> - Fix a typo in comment
>
> drivers/acpi/device_pm.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
> index 9dce1245689ca25..b657998ce728e4c 100644
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -681,7 +681,22 @@ static int acpi_dev_pm_get_state(struct device *dev, struct acpi_device *adev,
> d_min = ret;
> wakeup = device_may_wakeup(dev) && adev->wakeup.flags.valid
> && adev->wakeup.sleep_state >= target_state;
> + } else if (device_may_wakeup(dev) && dev->power.wakeirq) {
> + /*
> + * The ACPI subsystem doesn't manage the wake bit for IRQs
> + * defined with ExclusiveAndWake and SharedAndWake. Instead we
> + * expect them to be managed via the PM subsystem. Drivers
> + * should call dev_pm_set_wake_irq to register an IRQ as a wake
> + * source.
> + *
> + * If a device has a wake IRQ attached we need to check the
> + * _S0W method to get the correct wake D-state. Otherwise we
> + * end up putting the device into D3Cold which will more than
> + * likely disable wake functionality.
> + */
> + wakeup = true;
> } else {
> + /* ACPI GPE is specified in _PRW. */
> wakeup = adev->wakeup.flags.valid;
> }
>
> --
I can apply this one readily if that helps.
It doesn't depend on anything else in the series AFAICS.
It looks like patch [01/13] could also be applied right away, but
probably it is not for the ACPI tree.
I have a small comment to patch [06/13], and after that is addressed
it could be applied right away too I suppose, but the rest of the
patches need ACKs from the respective maintainers.
next prev parent reply other threads:[~2022-09-29 19:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:19 [PATCH v6 00/13] acpi: i2c: Use SharedAndWake and ExclusiveAndWake to enable wake irq Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 01/13] HID: i2c-hid: Use PM subsystem to manage " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 02/13] Input: elan_i2c - " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 03/13] Input: elants_i2c " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 04/13] Input: raydium_ts_i2c " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 05/13] gpiolib: acpi: Add wake_capable variants of acpi_dev_gpio_irq_get Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Raul E Rangel
2022-09-29 19:17 ` Rafael J. Wysocki
2022-09-29 19:27 ` Raul Rangel
2022-09-29 19:38 ` Rafael J. Wysocki
2022-09-29 21:20 ` Raul Rangel
2022-09-29 23:22 ` Dmitry Torokhov
2022-09-30 17:13 ` Rafael J. Wysocki
2022-09-30 17:42 ` Andy Shevchenko
2022-09-30 17:54 ` Rafael J. Wysocki
2022-09-30 17:55 ` Dmitry Torokhov
2022-10-15 16:56 ` Rafael J. Wysocki
2022-10-17 14:53 ` Raul Rangel
2022-11-07 18:36 ` Raul Rangel
2022-11-22 22:13 ` Dmitry Torokhov
2022-09-29 16:19 ` [PATCH v6 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Raul E Rangel
2022-10-01 22:51 ` Wolfram Sang
2022-09-29 16:19 ` [PATCH v6 08/13] ACPI: PM: Take wake IRQ into consideration when entering suspend-to-idle Raul E Rangel
2022-09-29 19:06 ` Rafael J. Wysocki [this message]
2022-09-29 16:19 ` [PATCH v6 09/13] HID: i2c-hid: acpi: Stop setting wakeup_capable Raul E Rangel
2022-11-21 14:49 ` Andy Shevchenko
2022-11-30 18:06 ` Raul Rangel
2023-01-12 19:57 ` Werner Sembach
2023-01-12 20:09 ` Limonciello, Mario
2022-09-29 16:19 ` [PATCH v6 10/13] HID: i2c-hid: Don't set wake_capable and wake_irq Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 11/13] Input: elan_i2c - " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 12/13] Input: elants_i2c " Raul E Rangel
2022-09-29 16:19 ` [PATCH v6 13/13] Input: raydium_ts_i2c " Raul E Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0ho2vwoUDk_CFRi3ztA8mz3pWWY1OqwLK4NdXrHSbKjmw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jingle.wu@emc.com.tw \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).