From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCCAC433E0 for ; Wed, 24 Jun 2020 15:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 694AF206EB for ; Wed, 24 Jun 2020 15:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593010824; bh=ADS01e6UuwaXesf7T/YCyhdR1bhuKePkQrZwLqEV8XY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=JWVDf95Jh4BRHyaAdSexdIXPap4hh8sWphNZtQvarhVIs9Q0o79DZpcZOMP/8Na5H 69/Q+XNa0VGe5Vc7d4FaaE87TWtZeVfcxA7HzNoBiKJFu8YdFOpjQM7enCgBFvkIZJ 8UGYDJtHJWptdG2cgyZjLBClwCrXvYipZNUyTGNQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389818AbgFXPAX (ORCPT ); Wed, 24 Jun 2020 11:00:23 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:41149 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389043AbgFXPAX (ORCPT ); Wed, 24 Jun 2020 11:00:23 -0400 Received: by mail-ot1-f67.google.com with SMTP id k15so2167936otp.8; Wed, 24 Jun 2020 08:00:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eykhWQcNNxAwrKLr1Dkv70utXgS770FMiPrM6b8KPjc=; b=hkHeIouE0X74Rn2j8Igk/XY/4jOLE8DlfLi2yerUJcVKFK2NOOdBPJbwUwayFt9GQG WS5VZ/1HkAVQNdCD4Qw61wOfGp6p+kXSgTgiww5uGvWDHsnEHfavrw6TnCFiUMRwADaM Gd+nb664kj4N2CTEWKSFKzOnyCSUoM4CJG3iDxh/Lw+ARo+KhKTWSa8WSAFoE6O8KrIX QqKdDMntr1VZNUZn6VVodgXBpCRtWjQhYS0+9AUQSTZC3SGGEvb1PV8vyNRtbJ0zOqwk BQ8u0iVIWuDqnwsJPwDKJqWcWWf2h1JXRTSBmURpbESG15E4O2MZV9ck1Df4AXDW5atK cjyQ== X-Gm-Message-State: AOAM5336mnoguDHEPE24ywgzFB52m96XoeX9G0UfGu4pFJP+u37TYJUY FSdV+YfFLbHlIQYcFgyWWiYMoRFz/kyJSlvVZAw= X-Google-Smtp-Source: ABdhPJxTfu2nRQ0ID+eDw+0oWm7stVdBgfOBXZxtPamhCD54VzLFyKUSp9gBGIPEG0mIIAqQQkSpe0tvPBek2gXWEWg= X-Received: by 2002:a9d:7d15:: with SMTP id v21mr22236731otn.118.1593010820398; Wed, 24 Jun 2020 08:00:20 -0700 (PDT) MIME-Version: 1.0 References: <2336e15d-ff4b-bbb6-c701-dbf3aa110fcd@redhat.com> <20200608112211.12125-1-andrzej.p@collabora.com> <20200608112211.12125-4-andrzej.p@collabora.com> In-Reply-To: <20200608112211.12125-4-andrzej.p@collabora.com> From: "Rafael J. Wysocki" Date: Wed, 24 Jun 2020 17:00:09 +0200 Message-ID: Subject: Re: [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex To: Andrzej Pietrasiewicz Cc: Linux PM , ACPI Devel Maling List , Linux Kernel Mailing List , linux-iio@vger.kernel.org, Linux ARM , Linux Samsung SoC , linux-input@vger.kernel.org, linux-tegra , patches@opensource.cirrus.com, ibm-acpi-devel@lists.sourceforge.net, Platform Driver , "Rafael J . Wysocki" , Len Brown , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kukjin Kim , Krzysztof Kozlowski , Dmitry Torokhov , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Sylvain Lemieux , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Barry Song , Michael Hennerich , Nick Dyer , Hans de Goede , Ferruh Yigit , Sangwon Jee , Peter Hutterer , Henrique de Moraes Holschuh , Collabora Kernel ML Content-Type: text/plain; charset="UTF-8" Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz wrote: > > Inspecting input device's 'users' member should be done under device's > mutex, so add appropriate invocations. > > Signed-off-by: Andrzej Pietrasiewicz This looks like a fix that might be applied independently of the other patches in the series. Do you want me to pick it up? > --- > drivers/acpi/button.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c > index 78cfc70cb320..ff7ab291f678 100644 > --- a/drivers/acpi/button.c > +++ b/drivers/acpi/button.c > @@ -456,13 +456,16 @@ static int acpi_button_resume(struct device *dev) > { > struct acpi_device *device = to_acpi_device(dev); > struct acpi_button *button = acpi_driver_data(device); > + struct input_dev *input = button->input; > > button->suspended = false; > - if (button->type == ACPI_BUTTON_TYPE_LID && button->input->users) { > + mutex_lock(&input->mutex); > + if (button->type == ACPI_BUTTON_TYPE_LID && input->users) { > button->last_state = !!acpi_lid_evaluate_state(device); > button->last_time = ktime_get(); > acpi_lid_initialize_state(device); > } > + mutex_unlock(&input->mutex); > return 0; > } > #endif > -- > 2.17.1 >