* [PATCH 0/2] Convert Goodix touchscreen to json-schema @ 2020-01-07 13:09 Benjamin Gaignard 2020-01-07 13:09 ` [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema Benjamin Gaignard 2020-01-07 13:09 ` [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema Benjamin Gaignard 0 siblings, 2 replies; 7+ messages in thread From: Benjamin Gaignard @ 2020-01-07 13:09 UTC (permalink / raw) To: dmitry.torokhov, robh+dt, mark.rutland Cc: linux-input, devicetree, linux-kernel, yannick.fertre, Benjamin Gaignard This series convert Goodix touchscreen used on STM32 boards to json-schema. Before converting goodix bindings itself it add a schema for common touchscreen properties. Benjamin Gaignard (2): dt-bindings: touchscreen: Add touchscreen schema dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema .../bindings/input/touchscreen/goodix.txt | 50 ---------------- .../bindings/input/touchscreen/goodix.yaml | 69 ++++++++++++++++++++++ .../bindings/input/touchscreen/touchscreen.yaml | 63 ++++++++++++++++++++ 3 files changed, 132 insertions(+), 50 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix.txt create mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix.yaml create mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml -- 2.15.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema 2020-01-07 13:09 [PATCH 0/2] Convert Goodix touchscreen to json-schema Benjamin Gaignard @ 2020-01-07 13:09 ` Benjamin Gaignard 2020-01-07 17:47 ` Rob Herring 2020-01-07 13:09 ` [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema Benjamin Gaignard 1 sibling, 1 reply; 7+ messages in thread From: Benjamin Gaignard @ 2020-01-07 13:09 UTC (permalink / raw) To: dmitry.torokhov, robh+dt, mark.rutland Cc: linux-input, devicetree, linux-kernel, yannick.fertre, Benjamin Gaignard Add touchscreen schema for common properties Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- .../bindings/input/touchscreen/touchscreen.yaml | 63 ++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml new file mode 100644 index 000000000000..f6e7c73ef14e --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/touchscreen.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Common touchscreen Bindings + +maintainers: + - Dmitry Torokhov <dmitry.torokhov@gmail.com> + +properties: + touchscreen-min-x: + description: minimum x coordinate reported (0 if not set) + + touchscreen-min-y: + description: minimum y coordinate reported (0 if not set) + + touchscreen-size-x: + description: horizontal resolution of touchscreen (maximum x coordinate reported + 1) + + touchscreen-size-y: + description: vertical resolution of touchscreen (maximum y coordinate reported + 1) + + touchscreen-max-pressure: + description: maximum reported pressure (arbitrary range dependent on the controller) + + touchscreen-min-pressure: + description: minimum pressure on the touchscreen to be achieved in order for the + touchscreen driver to report a touch event. + + touchscreen-fuzz-x: + description: horizontal noise value of the absolute input device (in pixels) + + touchscreen-fuzz-y: + description: vertical noise value of the absolute input device (in pixels) + + touchscreen-fuzz-pressure: + description: pressure noise value of the absolute input device (arbitrary range + dependent on the controller) + + touchscreen-average-samples: + description: Number of data samples which are averaged for each read (valid values + dependent on the controller) + + touchscreen-inverted-x: + description: X axis is inverted (boolean) + type: boolean + + touchscreen-inverted-y: + description: Y axis is inverted (boolean) + type: boolean + + touchscreen-swapped-x-y: + description: X and Y axis are swapped (boolean) + Swapping is done after inverting the axis + type: boolean + + touchscreen-x-mm: + description: horizontal length in mm of the touchscreen + + touchscreen-y-mm: + description: vertical length in mm of the touchscreen -- 2.15.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema 2020-01-07 13:09 ` [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema Benjamin Gaignard @ 2020-01-07 17:47 ` Rob Herring 0 siblings, 0 replies; 7+ messages in thread From: Rob Herring @ 2020-01-07 17:47 UTC (permalink / raw) To: Benjamin Gaignard Cc: Dmitry Torokhov, Mark Rutland, Linux Input, devicetree, linux-kernel, Yannick Fertre On Tue, Jan 7, 2020 at 7:09 AM Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > > Add touchscreen schema for common properties > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../bindings/input/touchscreen/touchscreen.yaml | 63 ++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml Don't just add schema. Remove the old definitions. To avoid updating a bunch of references to touchscreen.txt, I just put a 'see touchscreen.yaml' in it. > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > new file mode 100644 > index 000000000000..f6e7c73ef14e > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/touchscreen.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common touchscreen Bindings > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@gmail.com> > + > +properties: > + touchscreen-min-x: > + description: minimum x coordinate reported (0 if not set) You need a type reference on a bunch of these. And "(0 if not set)" sounds like a 'default' constraint. > + > + touchscreen-min-y: > + description: minimum y coordinate reported (0 if not set) > + > + touchscreen-size-x: > + description: horizontal resolution of touchscreen (maximum x coordinate reported + 1) > + > + touchscreen-size-y: > + description: vertical resolution of touchscreen (maximum y coordinate reported + 1) I don't think it makes sense if both of these aren't present, so you need: dependencies: touchscreen-size-x: [ touchscreen-size-y ] touchscreen-size-y: [ touchscreen-size-x ] > + > + touchscreen-max-pressure: > + description: maximum reported pressure (arbitrary range dependent on the controller) > + > + touchscreen-min-pressure: > + description: minimum pressure on the touchscreen to be achieved in order for the > + touchscreen driver to report a touch event. > + > + touchscreen-fuzz-x: > + description: horizontal noise value of the absolute input device (in pixels) > + > + touchscreen-fuzz-y: > + description: vertical noise value of the absolute input device (in pixels) > + > + touchscreen-fuzz-pressure: > + description: pressure noise value of the absolute input device (arbitrary range > + dependent on the controller) > + > + touchscreen-average-samples: > + description: Number of data samples which are averaged for each read (valid values > + dependent on the controller) > + > + touchscreen-inverted-x: > + description: X axis is inverted (boolean) > + type: boolean > + > + touchscreen-inverted-y: > + description: Y axis is inverted (boolean) > + type: boolean > + > + touchscreen-swapped-x-y: > + description: X and Y axis are swapped (boolean) > + Swapping is done after inverting the axis > + type: boolean > + > + touchscreen-x-mm: > + description: horizontal length in mm of the touchscreen > + > + touchscreen-y-mm: > + description: vertical length in mm of the touchscreen Same dependencies here. Rob ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema 2020-01-07 13:09 [PATCH 0/2] Convert Goodix touchscreen to json-schema Benjamin Gaignard 2020-01-07 13:09 ` [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema Benjamin Gaignard @ 2020-01-07 13:09 ` Benjamin Gaignard 2020-01-07 13:38 ` Bastien Nocera 2020-01-07 17:56 ` Rob Herring 1 sibling, 2 replies; 7+ messages in thread From: Benjamin Gaignard @ 2020-01-07 13:09 UTC (permalink / raw) To: dmitry.torokhov, robh+dt, mark.rutland Cc: linux-input, devicetree, linux-kernel, yannick.fertre, Benjamin Gaignard Convert the Goodix binding to DT schema format using json-schema Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- .../bindings/input/touchscreen/goodix.txt | 50 ---------------- .../bindings/input/touchscreen/goodix.yaml | 69 ++++++++++++++++++++++ 2 files changed, 69 insertions(+), 50 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix.txt create mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix.yaml diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt deleted file mode 100644 index fc03ea4cf5ab..000000000000 --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt +++ /dev/null @@ -1,50 +0,0 @@ -Device tree bindings for Goodix GT9xx series touchscreen controller - -Required properties: - - - compatible : Should be "goodix,gt1151" - or "goodix,gt5663" - or "goodix,gt5688" - or "goodix,gt911" - or "goodix,gt9110" - or "goodix,gt912" - or "goodix,gt927" - or "goodix,gt9271" - or "goodix,gt928" - or "goodix,gt967" - - reg : I2C address of the chip. Should be 0x5d or 0x14 - - interrupts : Interrupt to which the chip is connected - -Optional properties: - - - irq-gpios : GPIO pin used for IRQ. The driver uses the - interrupt gpio pin as output to reset the device. - - reset-gpios : GPIO pin used for reset - - AVDD28-supply : Analog power supply regulator on AVDD28 pin - - VDDIO-supply : GPIO power supply regulator on VDDIO pin - - touchscreen-inverted-x - - touchscreen-inverted-y - - touchscreen-size-x - - touchscreen-size-y - - touchscreen-swapped-x-y - -The touchscreen-* properties are documented in touchscreen.txt in this -directory. - -Example: - - i2c@00000000 { - /* ... */ - - gt928@5d { - compatible = "goodix,gt928"; - reg = <0x5d>; - interrupt-parent = <&gpio>; - interrupts = <0 0>; - - irq-gpios = <&gpio1 0 0>; - reset-gpios = <&gpio1 1 0>; - }; - - /* ... */ - }; diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml new file mode 100644 index 000000000000..05b52d359ac5 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/goodix.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Goodix GT9xx series touchscreen controller Bindings + +maintainers: + - Dmitry Torokhov <dmitry.torokhov@gmail.com> + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + enum: + - goodix,gt1151 + - goodix,gt5663 + - goodix,gt5688 + - goodix,gt911 + - goodix,gt9110 + - goodix,gt912 + - goodix,gt927 + - goodix,gt9271 + - goodix,gt928 + - goodix,gt967 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + irq-gpios: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + AVDD28-supply: + description: Analog power supply regulator on AVDD28 pin + + VDDIO-supply: + description: GPIO power supply regulator on VDDIO pin + +additionalProperties: false + +required: + - compatible + - reg + - interrupts + +examples: +- | + i2c@00000000 { + #address-cells = <1>; + #size-cells = <0>; + gt928@5d { + compatible = "goodix,gt928"; + reg = <0x5d>; + interrupt-parent = <&gpio>; + interrupts = <0 0>; + irq-gpios = <&gpio1 0 0>; + reset-gpios = <&gpio1 1 0>; + }; + }; + +... -- 2.15.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema 2020-01-07 13:09 ` [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema Benjamin Gaignard @ 2020-01-07 13:38 ` Bastien Nocera 2020-01-07 18:02 ` Rob Herring 2020-01-07 17:56 ` Rob Herring 1 sibling, 1 reply; 7+ messages in thread From: Bastien Nocera @ 2020-01-07 13:38 UTC (permalink / raw) To: Benjamin Gaignard, dmitry.torokhov, robh+dt, mark.rutland Cc: linux-input, devicetree, linux-kernel, yannick.fertre On Tue, 2020-01-07 at 14:09 +0100, Benjamin Gaignard wrote: > Convert the Goodix binding to DT schema format using json-schema I don't have an opinion on the migration itself, but this really should not lose any of the descriptions that were in the old text file. > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../bindings/input/touchscreen/goodix.txt | 50 ------------ > ---- > .../bindings/input/touchscreen/goodix.yaml | 69 > ++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 50 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/input/touchscreen/goodix.txt > create mode 100644 > Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > deleted file mode 100644 > index fc03ea4cf5ab..000000000000 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -Device tree bindings for Goodix GT9xx series touchscreen controller > - > -Required properties: > - > - - compatible : Should be "goodix,gt1151" > - or "goodix,gt5663" > - or "goodix,gt5688" > - or "goodix,gt911" > - or "goodix,gt9110" > - or "goodix,gt912" > - or "goodix,gt927" > - or "goodix,gt9271" > - or "goodix,gt928" > - or "goodix,gt967" > - - reg : I2C address of the chip. Should be > 0x5d or 0x14 > - - interrupts : Interrupt to which the chip is > connected > - > -Optional properties: > - > - - irq-gpios : GPIO pin used for IRQ. The driver uses the > - interrupt gpio pin as output to reset the > device. > - - reset-gpios : GPIO pin used for reset > - - AVDD28-supply : Analog power supply regulator on AVDD28 pin > - - VDDIO-supply : GPIO power supply regulator on VDDIO > pin > - - touchscreen-inverted-x > - - touchscreen-inverted-y > - - touchscreen-size-x > - - touchscreen-size-y > - - touchscreen-swapped-x-y > - > -The touchscreen-* properties are documented in touchscreen.txt in > this > -directory. > - > -Example: > - > - i2c@00000000 { > - /* ... */ > - > - gt928@5d { > - compatible = "goodix,gt928"; > - reg = <0x5d>; > - interrupt-parent = <&gpio>; > - interrupts = <0 0>; > - > - irq-gpios = <&gpio1 0 0>; > - reset-gpios = <&gpio1 1 0>; > - }; > - > - /* ... */ > - }; > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > new file mode 100644 > index 000000000000..05b52d359ac5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/goodix.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Goodix GT9xx series touchscreen controller Bindings > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@gmail.com> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - goodix,gt1151 > + - goodix,gt5663 > + - goodix,gt5688 > + - goodix,gt911 > + - goodix,gt9110 > + - goodix,gt912 > + - goodix,gt927 > + - goodix,gt9271 > + - goodix,gt928 > + - goodix,gt967 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + irq-gpios: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + AVDD28-supply: > + description: Analog power supply regulator on AVDD28 pin > + > + VDDIO-supply: > + description: GPIO power supply regulator on VDDIO pin > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + > +examples: > +- | > + i2c@00000000 { > + #address-cells = <1>; > + #size-cells = <0>; > + gt928@5d { > + compatible = "goodix,gt928"; > + reg = <0x5d>; > + interrupt-parent = <&gpio>; > + interrupts = <0 0>; > + irq-gpios = <&gpio1 0 0>; > + reset-gpios = <&gpio1 1 0>; > + }; > + }; > + > +... ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema 2020-01-07 13:38 ` Bastien Nocera @ 2020-01-07 18:02 ` Rob Herring 0 siblings, 0 replies; 7+ messages in thread From: Rob Herring @ 2020-01-07 18:02 UTC (permalink / raw) To: Bastien Nocera Cc: Benjamin Gaignard, Dmitry Torokhov, Mark Rutland, Linux Input, devicetree, linux-kernel, Yannick Fertre On Tue, Jan 7, 2020 at 7:38 AM Bastien Nocera <hadess@hadess.net> wrote: > > On Tue, 2020-01-07 at 14:09 +0100, Benjamin Gaignard wrote: > > Convert the Goodix binding to DT schema format using json-schema > > I don't have an opinion on the migration itself, but this really should > not lose any of the descriptions that were in the old text file. To some extent, yes. Any information specific to the device should be. Anything generic can be dropped. I see 2 cases that should be kept: > > - - reg : I2C address of the chip. Should be > > 0x5d or 0x14 'I2C address of the chip' can be dropped as that's every 'reg' property for I2C devices. The addresses can be expressed as constraints. > > - - irq-gpios : GPIO pin used for IRQ. The driver uses the > > - interrupt gpio pin as output to reset the > > device. Also useful info. Rob ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema 2020-01-07 13:09 ` [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema Benjamin Gaignard 2020-01-07 13:38 ` Bastien Nocera @ 2020-01-07 17:56 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2020-01-07 17:56 UTC (permalink / raw) To: Benjamin Gaignard Cc: Dmitry Torokhov, Mark Rutland, Linux Input, devicetree, linux-kernel, Yannick Fertre On Tue, Jan 7, 2020 at 7:09 AM Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > > Convert the Goodix binding to DT schema format using json-schema > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../bindings/input/touchscreen/goodix.txt | 50 ---------------- > .../bindings/input/touchscreen/goodix.yaml | 69 ++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 50 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix.txt > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > deleted file mode 100644 > index fc03ea4cf5ab..000000000000 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -Device tree bindings for Goodix GT9xx series touchscreen controller > - > -Required properties: > - > - - compatible : Should be "goodix,gt1151" > - or "goodix,gt5663" > - or "goodix,gt5688" > - or "goodix,gt911" > - or "goodix,gt9110" > - or "goodix,gt912" > - or "goodix,gt927" > - or "goodix,gt9271" > - or "goodix,gt928" > - or "goodix,gt967" > - - reg : I2C address of the chip. Should be 0x5d or 0x14 > - - interrupts : Interrupt to which the chip is connected > - > -Optional properties: > - > - - irq-gpios : GPIO pin used for IRQ. The driver uses the > - interrupt gpio pin as output to reset the device. > - - reset-gpios : GPIO pin used for reset > - - AVDD28-supply : Analog power supply regulator on AVDD28 pin > - - VDDIO-supply : GPIO power supply regulator on VDDIO pin > - - touchscreen-inverted-x > - - touchscreen-inverted-y > - - touchscreen-size-x > - - touchscreen-size-y > - - touchscreen-swapped-x-y > - > -The touchscreen-* properties are documented in touchscreen.txt in this > -directory. > - > -Example: > - > - i2c@00000000 { > - /* ... */ > - > - gt928@5d { > - compatible = "goodix,gt928"; > - reg = <0x5d>; > - interrupt-parent = <&gpio>; > - interrupts = <0 0>; > - > - irq-gpios = <&gpio1 0 0>; > - reset-gpios = <&gpio1 1 0>; > - }; > - > - /* ... */ > - }; > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > new file mode 100644 > index 000000000000..05b52d359ac5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/goodix.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Goodix GT9xx series touchscreen controller Bindings > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@gmail.com> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - goodix,gt1151 > + - goodix,gt5663 > + - goodix,gt5688 > + - goodix,gt911 > + - goodix,gt9110 > + - goodix,gt912 > + - goodix,gt927 > + - goodix,gt9271 > + - goodix,gt928 > + - goodix,gt967 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + irq-gpios: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + AVDD28-supply: > + description: Analog power supply regulator on AVDD28 pin > + > + VDDIO-supply: > + description: GPIO power supply regulator on VDDIO pin > + > +additionalProperties: false This doesn't work if you have any touchscreen properties as this doesn't account for things referenced. You need add them in this schema: touchscreen-inverted-x: true This serves 2 purposes. It prevents additional properties not defined here and defines which of the common properties are valid for this device. Rob ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-07 18:03 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-07 13:09 [PATCH 0/2] Convert Goodix touchscreen to json-schema Benjamin Gaignard 2020-01-07 13:09 ` [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema Benjamin Gaignard 2020-01-07 17:47 ` Rob Herring 2020-01-07 13:09 ` [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema Benjamin Gaignard 2020-01-07 13:38 ` Bastien Nocera 2020-01-07 18:02 ` Rob Herring 2020-01-07 17:56 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).