From: Amit Pundir <amit.pundir@linaro.org>
To: kholk11@gmail.com
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
rydberg@bitmath.org, priv.luk@gmail.com,
linux-input@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
marijns95@gmail.com, Konrad Dybcio <konradybcio@gmail.com>,
martin.botka1@gmail.com, phone-devel@vger.kernel.org,
dt <devicetree@vger.kernel.org>,
krzk@kernel.org, andy.shevchenko@gmail.com
Subject: Re: [PATCH v9 0/3] Add Novatek NT36xxx touchscreen driver
Date: Fri, 27 Nov 2020 11:53:25 +0530 [thread overview]
Message-ID: <CAMi1Hd00rPU2nUVxK000F=oP=33EKDKXLDymz9hbZT0XEGQZuw@mail.gmail.com> (raw)
In-Reply-To: <20201028221302.66583-1-kholk11@gmail.com>
On Thu, 29 Oct 2020 at 06:32, <kholk11@gmail.com> wrote:
>
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> This patch series adds support for the Novatek NT36xxx Series' In-Cell
> touchscreen (integrated into the DriverIC).
>
> This patch series has been tested against the following devices:
> - Sony Xperia 10 (SDM630 Ganges Kirin)
> - Sony Xperia 10 Plus (SDM636 Ganges Mermaid)
>
Tested the patch series on Xiaomi Poco F1 (SDM845 Beryllium, Novatek
NT36672A IC).
For the whole series:
Tested-by: Amit Pundir <amit.pundir@linaro.org>
Regards,
Amit Pundir
> Changes in v2:
> - Fixed sparse warnings from lkp kernel test robot
>
> Changes in v3 (as requested by Dmitry Torokhov):
> - Using shorthand u16/u32 (sorry for the overlook!)
> - Now using more input and touchscreen APIs
> - Fixed useless workqueue involvements
> - Removed useless locking
> - Switched reads and writes to use regmap
> - Moved header contents to nt36xxx.c
> - Fixed reset gpio handling
> - Other cleanups
> - P.S.: Thanks, Dmitry!
>
> Changes in v4:
> - Fixed regmap read length for CRC_ERR_FLAG final check
> - Fixed YAML binding, as requested by Krzysztof Kozlowski
>
> Changes in v5:
> - Replaced subsystem maintainer's name with .. mine,
> usage of additionalProperties to unevaluatedProperties
> and a typo fix for reset-gpios as per Rob Herring's review
> - Changed compatible string as per Krzysztof K. request
> - Renamed the novatek,nt36xxx.yaml file to just nt36xxx.yaml
> in order to now reflect the driver name instead of the DT
> compatible
> - Fixed blank line at EOF
>
> Changes in v6:
> - Removed include of_gpio.h, added mod_devicetable.h and
> gpio/consumer.h
> - Added kerneldoc to relevant functions/enum
> - Used traditional patterns for error checking where possible
> - Documented calls to usleep/msleep
> - Using be16_to_cpu / get_unaligned_be16 where possible
> - Added helper for CRC error check on retrieved buffer
> - Decreased indentation in the CRC reboot recovery function
> - Removed instances of error code sum
> - Dropped all likely/unlikely optimization as per request
> - Removed redundant reset_gpio checks
> - Dropped of_match_ptr and ifdefs for CONFIG_OF
>
> Changes in v7:
> - Fixed typo in nt36xxx.c
>
> Changes in v8:
> - Fixed typo reset-gpio -> reset-gpios in dt-bindings
>
> Changes in v9:
> - Includes are now sorted
> - Used proposed sizeof variable instead of sizeof type
> - Fixed a return value check for common pattern
> - Added NULL check to devm_kasprintf call
> - Returning ret on probe function to be consistent
>
> AngeloGioacchino Del Regno (3):
> dt-bindings: Add vendor prefix for Novatek Microelectronics Corp.
> Input: Add Novatek NT36xxx touchscreen driver
> dt-bindings: touchscreen: Add binding for Novatek NT36xxx series
> driver
>
> .../bindings/input/touchscreen/nt36xxx.yaml | 59 ++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> drivers/input/touchscreen/Kconfig | 12 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/nt36xxx.c | 894 ++++++++++++++++++
> drivers/input/touchscreen/nt36xxx.h | 122 +++
> 6 files changed, 1090 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nt36xxx.yaml
> create mode 100644 drivers/input/touchscreen/nt36xxx.c
> create mode 100644 drivers/input/touchscreen/nt36xxx.h
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-11-27 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 22:12 [PATCH v9 0/3] Add Novatek NT36xxx touchscreen driver kholk11
2020-10-28 22:13 ` [PATCH v9 1/3] dt-bindings: Add vendor prefix for Novatek Microelectronics Corp kholk11
2020-10-29 15:50 ` Rob Herring
2020-10-29 17:22 ` AngeloGioacchino Del Regno
2020-10-28 22:13 ` [PATCH v9 2/3] Input: Add Novatek NT36xxx touchscreen driver kholk11
2020-12-07 6:43 ` Dmitry Torokhov
2021-01-13 13:03 ` AngeloGioacchino Del Regno
2023-06-26 23:59 ` Konrad Dybcio
2020-10-28 22:13 ` [PATCH v9 3/3] dt-bindings: touchscreen: Add binding for Novatek NT36xxx series driver kholk11
2020-11-23 10:12 ` [PATCH v9 0/3] Add Novatek NT36xxx touchscreen driver Amit Pundir
2020-11-26 17:09 ` AngeloGioacchino Del Regno
2020-11-27 6:23 ` Amit Pundir [this message]
2022-04-26 7:55 ` Danct12
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMi1Hd00rPU2nUVxK000F=oP=33EKDKXLDymz9hbZT0XEGQZuw@mail.gmail.com' \
--to=amit.pundir@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kholk11@gmail.com \
--cc=konradybcio@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=martin.botka1@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=priv.luk@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).