From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95718C4346E for ; Tue, 29 Sep 2020 07:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 274D420936 for ; Tue, 29 Sep 2020 07:59:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z/FVuhB6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbgI2H70 (ORCPT ); Tue, 29 Sep 2020 03:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgI2H70 (ORCPT ); Tue, 29 Sep 2020 03:59:26 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D402CC061755 for ; Tue, 29 Sep 2020 00:59:25 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id a9so3775968wmm.2 for ; Tue, 29 Sep 2020 00:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z44OCwOHJFAg70e5aEAiWS8XZCl9H96J8tZarWdkMhw=; b=Z/FVuhB6HuycrwymG80hUaxXIvXS6rU4TG69hlvG+ssusxVSVTJLh0ht4r3+WubNj5 pr1etCcepdla4i8XyhR+EHVnudUFAyVS4HcImrMUtW9/KE3fnqZPwX8gQkq3+Z7JUvne vhS3cq8/T0ve4f8JXT20BKpX7ZLj7xxHy3YTKepUFmJXieFECi1RrRyKCNXx8MMkfmna T7CA0BYn55VTGYB0MlioT8P1EiFkPRtaK21hPFWzIK3k0oCZSytZC3lOzUugRSolw25C x9FMzJeshW7diTqn154NjByRse9ZCJlSwLzXOGDNHYUSAD5sY2ZaWGZTCyIEsyocTbbP XpWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z44OCwOHJFAg70e5aEAiWS8XZCl9H96J8tZarWdkMhw=; b=CDBTOb7vWv2A/BWjdPi+q+oDWw719LbwJaA4nZ4j9dCgq5j0T2wIrf5104XkpA8ulv u6t4aIwAgSZ7OvJIyZu5iqY4sPQ0A8FlZpPgC0nXWA+X6sxVcMcPcY+1D1EfDuliGJYV ZWFCIJuEN08nmLzH+DepN4s8EfKxEMjX5hBEJI3LvtGpBk64N7t6qCEtRJJHfwMrBWYF YmSrRECzSF98WscSg5gxidEbwsIY1Dih8h5tuiyTpVJbMyICyZEaZeg1cCz+fp/GKn1o n0tuDI8aZGA6tC9iCzrS35VKN5K67M1SdbZWeLsYqre9TqEdeaUsPivkHW040a28gG6k c7Vg== X-Gm-Message-State: AOAM532OQe5YmAto8NrUQc5zMJ90WZ1dGJgciwfjd20v8oOGOjVWayr2 D+KqU5Yfy9TipfAZjFyoFzFABA+2s8dl1CJJu+D+Sw== X-Google-Smtp-Source: ABdhPJzIEZ5Ks8NozSFCE7r8LavP2lhCwbT/Q4oIeeySm7aOZ1AaUXYJS3rAIesL32tHY4cMAE2SVnySAJXWyvrB2hw= X-Received: by 2002:a7b:c750:: with SMTP id w16mr727455wmk.16.1601366364393; Tue, 29 Sep 2020 00:59:24 -0700 (PDT) MIME-Version: 1.0 References: <20200927123542.553852-1-kholk11@gmail.com> <20200927123542.553852-3-kholk11@gmail.com> <20200928215120.GP1681290@dtor-ws> In-Reply-To: <20200928215120.GP1681290@dtor-ws> From: Amit Pundir Date: Tue, 29 Sep 2020 13:28:48 +0530 Message-ID: Subject: Re: [PATCH v2 2/3] Input: Add Novatek NT36xxx touchscreen driver To: Dmitry Torokhov Cc: kholk11@gmail.com, Rob Herring , rydberg@bitmath.org, priv.luk@gmail.com, linux-input@vger.kernel.org, lkml , marijns95@gmail.com, Konrad Dybcio , martin.botka1@gmail.com, phone-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, 29 Sep 2020 at 03:21, Dmitry Torokhov wrote: > > On Mon, Sep 28, 2020 at 03:18:18PM +0530, Amit Pundir wrote: > > On Sun, 27 Sep 2020 at 18:06, wrote: > > > > > > From: AngeloGioacchino Del Regno > > > > > > This is a driver for the Novatek in-cell touch controller and > > > supports various chips from the NT36xxx family, currently > > > including NT36525, NT36672A, NT36676F, NT36772 and NT36870. > > > > > > Functionality like wake gestures and firmware flashing is not > > > included: I am not aware of any of these DrIC+Touch combo > > > chips not including a non-volatile memory and it should be > > > highly unlikely to find one, since the touch firmware is > > > embedded into the DriverIC one, which is obviously necessary > > > to drive the display unit. > > > > > > However, the necessary address for the firmware update > > > procedure was included into the address table in this driver > > > so, in the event that someone finds the need to implement it > > > for a reason or another, it will be pretty straightforward to. > > > > > > This driver is lightly based on the downstream implementation [1]. > > > [1] https://github.com/Rasenkai/caf-tsoft-Novatek-nt36xxx > > > > > > > This is so cool! > > > > Xiaomi PocoF1 phone uses same family touchscreen IC and I could > > test this series on that phone as well. > > > > However I do have to make a minor change to get it working. The > > downstream driver and even the github code you linked above use > > GPIO mapped IRQ, and I had to switch to that to get touchscreen > > working with your driver > > https://github.com/pundiramit/linux/commit/0a73eb656c1e80787dc195641ce7b0076fddb38e. > > I wonder if I'm missing any devicetree property other than interrupts? > > Simply specifying GPIO controller/pin as interrupt property should work, > there should be no need to parse custom GPIO property and convert it to > IRQ in the driver. > Indeed. I don't know what was tripping me off yesterday, but I got it working today with interrupt properties. Thank you. Regards, Amit Pundir > Thanks. > > -- > Dmitry