From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B37DC2BBD4 for ; Wed, 16 Dec 2020 10:38:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54FDC2337F for ; Wed, 16 Dec 2020 10:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbgLPKhz (ORCPT ); Wed, 16 Dec 2020 05:37:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726324AbgLPKhz (ORCPT ); Wed, 16 Dec 2020 05:37:55 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74A67C061285 for ; Wed, 16 Dec 2020 02:37:14 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id b73so24237927edf.13 for ; Wed, 16 Dec 2020 02:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bsYmkfEVvQqgzD1O+aSIpPO4CsKO+u0Ea3O6N1E481c=; b=E1gRWKOIK1EEv0yOYoQV3P1kGDMjSZejlfc9pBHAb3Ok+GL+cHeIuNDOxsqtxGH7Ef TItAt0jy8MO6I7jrtnl/EtsFj0NIH1iYsicmOwSPqBC1WpEozE46gxcOkApFuK3yM67H 3kAry0qXXNXvRk60jFkvTEZAae8Qsj65vAyBAUKRnpHNAwnLStkzn9Vg5UxXlJKu3xpl subhgINJugcYcDXVXRZF/R2lvLpHgjtSBDprPGBKaHegBUYMCngYjKnV0iQpkn1k/D1c YT3MZIqrg5HTPLQjTDj2jiSiTcHfX6l7pl6tyiuZGhOajtlGx2wi/GcI+CwN3awjt/km I9BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bsYmkfEVvQqgzD1O+aSIpPO4CsKO+u0Ea3O6N1E481c=; b=uVhp1OOWPY1ZJ/tTdZRoL27LLtw6ELApkBeKpUvdP0itaclX+IN/Z0aPrk3nXD3eXL U5EO+Sj+b2Kl2w+hObdtA7nWeimOKsQSE3MVWGFTW1PCrX6HBLSCJ0KWxYDNV74whqbp KE4RA1lHDEgXzeZkcYE1UkzV19k9CNDuhqsyEPUaBzIRPCuSpj7Vi6anbVaX+zr891SJ v7jhJAR2Q7EPO+KD6m27ui0xDJvSQ0CJetMSRftBVP6q3B+ztvtDBp183XNl3p+38mFT pk9W8Ni7hEmyacbyK3CrvtSVjQdR58o0Iu9Pm6LiyaDe58zoDtZazPaAw4QMAf6jWwUQ mXAQ== X-Gm-Message-State: AOAM533Pe9H4qtrbt0zWR/rggDViiZ8LWYV2Mw3a5Qq7LTGabsKMwaTS 7RINRFdwEZF8KEEjdQoTz2wizCwMnzOo/P1ipnOCmg== X-Google-Smtp-Source: ABdhPJwS+suNBsnmqdweQsc8crfYev1Kw3Evg9H2jPGzz2d+ZRjYUcCPzp4JsF4gaLfvS+QySSxQ51abC3XScJaIYz4= X-Received: by 2002:a50:b742:: with SMTP id g60mr32617780ede.113.1608115033228; Wed, 16 Dec 2020 02:37:13 -0800 (PST) MIME-Version: 1.0 References: <20201211164801.7838-1-nsaenzjulienne@suse.de> <20201211164801.7838-2-nsaenzjulienne@suse.de> In-Reply-To: <20201211164801.7838-2-nsaenzjulienne@suse.de> From: Bartosz Golaszewski Date: Wed, 16 Dec 2020 11:37:02 +0100 Message-ID: Subject: Re: [PATCH v6 01/11] firmware: raspberrypi: Keep count of all consumers To: Nicolas Saenz Julienne Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , LKML , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org, arm-soc , linux-devicetree , wahrenst@gmx.net, Linux Input , Dmitry Torokhov , Greg KH , devel@driverdev.osuosl.org, Philipp Zabel , linux-gpio , Linus Walleij , linux-clk , Stephen Boyd , linux-rpi-kernel@lists.infradead.org, Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Dec 11, 2020 at 5:48 PM Nicolas Saenz Julienne wrote: > > When unbinding the firmware device we need to make sure it has no > consumers left. Otherwise we'd leave them with a firmware handle > pointing at freed memory. > > Keep a reference count of all consumers and introduce rpi_firmware_put() > which will permit automatically decrease the reference count upon > unbinding consumer drivers. > > Suggested-by: Uwe Kleine-K=C3=B6nig > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli > > --- Reviewed-by: Bartosz Golaszewski