From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB11EC433ED for ; Mon, 3 May 2021 09:39:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90D6661077 for ; Mon, 3 May 2021 09:39:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232960AbhECJkl (ORCPT ); Mon, 3 May 2021 05:40:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25316 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231555AbhECJkl (ORCPT ); Mon, 3 May 2021 05:40:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620034788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ed4Fg0jmvz5izTHQmdOnBOoJKIPHVPN61DnFBqKQxak=; b=JrGmtn32E5vDfnpDA5+xh3B7ajaBYRt3BkbEQFhUm3gv2we+wZ5YTSXacqNDKbPkN4zMBJ pQCO5p7IfBRgwmvHkg4RNUaDDSlpoJ339rgy3o8wGsue0OmOoRSq4IeKs9Lxm+ifpz85tZ prGth3NRQj99iPFdLZKchL2kE808Res= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-Xlm71JkDObGcykilUKDb1g-1; Mon, 03 May 2021 05:39:46 -0400 X-MC-Unique: Xlm71JkDObGcykilUKDb1g-1 Received: by mail-pj1-f71.google.com with SMTP id f24-20020a17090aa798b029014e704b7ff5so4503747pjq.3 for ; Mon, 03 May 2021 02:39:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ed4Fg0jmvz5izTHQmdOnBOoJKIPHVPN61DnFBqKQxak=; b=QhR5M6BzAeESsWtNcol6AK1hnEVjZvXm+6oznNtVKs9th6bCKHlOM54ReMwjwAIv1X r82XWhUq8HQXx7yFU/OIvQ7pAru0pdpYwQqIeo8S2xDDJ6cLH/h+5TyEJWNUTPlppzrG yGalJpOqYfwH0FgHzYHKkBfEkvxIdBGioQtAsfzLkXFHVLrUb6x7sahm8ic0NcP5ECcG KlkAFDitMaIg4UycslQVwL8fxIWkVjVmzChOeLM4ChbEJHMYfVED+qLmgIbOF1lMuM0s +1ULEQpSzHz3LZfs01fzvrjpVhG93clen9S8yo/CXK7GRIxV/QNuHkqdJBn0qw043CRO rZ+Q== X-Gm-Message-State: AOAM531SNj7N4pJG1pY2RwccmtaAw9nQXJcHD+g0zUotjPEcGbQTyOQh JQjzvIdJbt4d042agkbNUfOrXFStFN8u6rfcvcjcpnW3HSGN9fg3TZnyyyKgSgy211zvvMMOg72 vsKzCrSujbbxI+FbWnEFrYt97bmwfRaooErwGSVI= X-Received: by 2002:a17:902:f686:b029:ee:d211:5a1b with SMTP id l6-20020a170902f686b02900eed2115a1bmr5621468plg.41.1620034785193; Mon, 03 May 2021 02:39:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVwcIIS+AzZDYRB2WFTm3qhlqHXnG6TXvo9ghWdIZfp2zf4V5g5e/VU5R60f6Ou/pYXvEqxrLZ+JvlRsSB070= X-Received: by 2002:a17:902:f686:b029:ee:d211:5a1b with SMTP id l6-20020a170902f686b02900eed2115a1bmr5621447plg.41.1620034784949; Mon, 03 May 2021 02:39:44 -0700 (PDT) MIME-Version: 1.0 References: <20210420131741.kdgxquhwqureih7c@tarta.nabijaczleweli.xyz> In-Reply-To: From: Benjamin Tissoires Date: Mon, 3 May 2021 11:39:34 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] Stylus-on-touchscreen device support To: Jiri Kosina Cc: =?UTF-8?B?0L3QsNCx?= , Peter Hutterer , "open list:HID CORE LAYER" , lkml Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, May 3, 2021 at 11:11 AM Jiri Kosina wrote: > > On Tue, 20 Apr 2021, =D0=BD=D0=B0=D0=B1 wrote: > > > > This patchset adds support for stylus-on-touchscreen devices as found= on > > > the OneMix 3 Pro and Dell Inspiron 15 7000 2-in-1 (7591), among other= s; > > > with it, they properly behave like a drawing tablet. > > > > > > Patches 2 and 4 funxionally depend on patch 1. > > > Patch 4 needs patch 3 to apply. > > > > > > The output of this patchset and the need for a kernel, rather than > > > userspace, patch was previously discussed here: > > > https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/5= 58#note_792834 > > > > > > Changes in v2: > > > Patch 4 now ANDs the secondary button with the tip switch, > > > since it's otherwise borderline useless to the user. > > > > > > Ahelenia Ziemia=C5=84ska (4): > > > HID: multitouch: require Finger field to mark Win8 reports as MT > > > HID: multitouch: set Stylus suffix for Stylus-application devices, = too > > > HID: input: replace outdated HID numbers+comments with macros > > > HID: input: work around Win8 stylus-on-touchscreen reporting > > > > > > drivers/hid/hid-input.c | 54 ++++++++++++++++++++++++++++++++++= -- > > > drivers/hid/hid-multitouch.c | 18 +++++++----- > > > 2 files changed, 62 insertions(+), 10 deletions(-) > > > > > > -- > > > 2.20.1 > > > > Bumping this after a monthish =E2=80=92 is it missing something? Am I? > > Benjamin had concerns about regressions and wanted to run a full battery > of testing on it. > > Benjamin, is there any outcome of that, please? > Sorry, no real outcome here. I ran the test suite, and there were no errors, until I realized that there are no tests regarding tablets, so it can't detect any regressions here. And then, the usual happens, no time to actually work on the test suite... = :( I'll do a "normal" review soon (i.e. today) Cheers, Benjamin