From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B72C64E7B for ; Wed, 2 Dec 2020 15:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44B8320B1F for ; Wed, 2 Dec 2020 15:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbgLBPVZ (ORCPT ); Wed, 2 Dec 2020 10:21:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37283 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726635AbgLBPVW (ORCPT ); Wed, 2 Dec 2020 10:21:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606922395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fFR2t3IjQI80xXgeJr/lLM6Ot3yuaPlWOezeBx0tbPI=; b=EHgBezg4BI+AW+nlYWzogXpTdqbxkir4TNi5eUZKSNYi+NGZ71P0cUz44hlun4AxOhdh6N Qdogz+9ERYqvXU33Ae3bUrslK/mXNgjCilqcgG1nEyoEYmFkbXfVTSwCDXytOd63qm9e9n 8ZTYaKi0+dBGnbKjnqpiHbZ9+lnC9f4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-205-R-nhSNQoPmKKqOFowcbNBg-1; Wed, 02 Dec 2020 10:19:54 -0500 X-MC-Unique: R-nhSNQoPmKKqOFowcbNBg-1 Received: by mail-pj1-f71.google.com with SMTP id s14so1213237pjk.4 for ; Wed, 02 Dec 2020 07:19:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fFR2t3IjQI80xXgeJr/lLM6Ot3yuaPlWOezeBx0tbPI=; b=Sft8E99xsgCSkEdR2MCT35YXiis9uIRDk/T7sePhOsPfioW59DXc+1GDwxzxfueLF7 LpLEVv7GpkEoShIPPnxkI1v8KNwnK7Y0f0r9zJS9o7qAFkhTQZ29ver3KiI4LQptHv9D 4T357KL9BhJVkd9lOZcGzxP4uNHMJKar+rCpCOjohO5O5iKh/MIB7T0NTVKqP0qu/Qt6 AYwVMgwN6IUl1KiK17fXvyZA3ESlNGL+likvCMIETJIsBcqUwfsJM5nTvyvgdloIxpZ7 jZpVFrb6b/jbXXJQTFuvgyXQvn5FCVeKL5YgovXArReJEIAlRk8KRVK5S0ue6KfoYZZj PxOw== X-Gm-Message-State: AOAM5333l/fGT51WWPRigFmdm3ttqz5+gKtTOa26LMQM3ySG7tB/PnEJ RAqcVkMQS7laNVfPgdY1g2EoIyTg48b+uJQAJ8aZb6UM+5hBY1kgq9BF4Dy/64KeJ03da3J7aYL NmnlP2dSZRsR9CmQSC1JTLRxDwVGWQiMjJc+75QM= X-Received: by 2002:a63:1414:: with SMTP id u20mr312492pgl.147.1606922392851; Wed, 02 Dec 2020 07:19:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzx1g9/LllhhTY2kqAX7DReYattvLk+1Zn+n8SVM7MqR/ECZ0g58ckaZi/4ZDUMErdOi5rr0+tT9celGmI9Nto= X-Received: by 2002:a63:1414:: with SMTP id u20mr312476pgl.147.1606922392587; Wed, 02 Dec 2020 07:19:52 -0800 (PST) MIME-Version: 1.0 References: <20201112004130.17290-1-dianders@chromium.org> In-Reply-To: From: Benjamin Tissoires Date: Wed, 2 Dec 2020 16:19:41 +0100 Message-ID: Subject: Re: [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p To: Doug Anderson Cc: Jiri Kosina , Greg Kroah-Hartman , Dmitry Torokhov , Andrea Borgia , Rob Herring , Kai-Heng Feng , Stephen Boyd , "open list:HID CORE LAYER" , Hans de Goede , Aaron Ma , Anson Huang , Bjorn Andersson , Catalin Marinas , Geert Uytterhoeven , Jiri Kosina , Krzysztof Kozlowski , Li Yang , Masahiro Yamada , Michael Walle , Olof Johansson , Pavel Balan , Shawn Guo , Vinod Koul , Will Deacon , Xiaofei Tan , You-Sheng Yang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Doug, On Tue, Dec 1, 2020 at 10:12 PM Doug Anderson wrote: > > Hi, > > On Wed, Nov 11, 2020 at 4:41 PM Douglas Anderson wrote: > > > > The goal of this series is to support the Goodix GT7375P touchscreen. > > This touchscreen is special because it has power sequencing > > requirements that necessitate driving a reset GPIO. > > > > To do this, we totally rejigger the way i2c-hid is organized so that > > it's easier to jam the Goodix support in there. > > > > This series was: > > - Tested on a device that uses normal i2c-hid. > > - Tested on a device that has a Goodix i2c-hid device. > > - Tested on an ACPI device, but an earlier version of the series. > > > > Changes in v6: > > - ACPI probe function should have been "static" > > - Don't export suspend/resume, just export dev_pm_ops from core. > > - Fixed crash in ACPI module (missing init of "client") > > - No need for regulator include in the core. > > - Removed i2c_device_id table from ACPI module. > > - Suspend/resume are no longer exported from the core. > > > > Changes in v5: > > - Add shutdown_tail op and use it in ACPI. > > - Added mention of i2c-hid in the yaml itself as per Rob. > > - Adjusted subject as per Rob. > > - i2chid_subclass_data => i2chid_ops. > > - power_up_device => power_up (same with power_down). > > - subclass => ops. > > > > Changes in v4: > > - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. > > - Fully rejigger so ACPI and OF are full subclasses. > > - Totally redid based on the new subclass system. > > > > Changes in v3: > > - Fixed compatible in example. > > - Removed Benjamin as a maintainer. > > - Rework to use subclassing. > > - Updated description. > > > > Changes in v2: > > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > > - Get timings based on the compatible string. > > - Use a separate compatible string for this new touchscreen. > > > > Douglas Anderson (4): > > HID: i2c-hid: Reorganize so ACPI and OF are separate modules > > arm64: defconfig: Update config names for i2c-hid rejigger > > dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix > > GT7375P > > HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core > > > > .../bindings/input/goodix,gt7375p.yaml | 65 +++++ > > arch/arm64/configs/defconfig | 3 +- > > drivers/hid/Makefile | 2 +- > > drivers/hid/i2c-hid/Kconfig | 47 +++- > > drivers/hid/i2c-hid/Makefile | 6 +- > > drivers/hid/i2c-hid/i2c-hid-acpi.c | 159 +++++++++++ > > drivers/hid/i2c-hid/i2c-hid-core.c | 254 +++--------------- > > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++ > > drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++ > > drivers/hid/i2c-hid/i2c-hid.h | 22 ++ > > include/linux/platform_data/i2c-hid.h | 41 --- > > 11 files changed, 596 insertions(+), 262 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > > create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c > > create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c > > create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c > > delete mode 100644 include/linux/platform_data/i2c-hid.h > > Are there any additional changes that folks would like with this > series? It's not crazy urgent to get it in, but it touches enough > lines of code that it'd be nice to get it in before other patches land > and it gets merge conflicts. Sorry for the delay. I was having an internal deadline last week. I just re-read the code, and I am quite happy with it. I also just tested it on the i2c-hid w/ acpi machine I have here, and it seems OK. So other than that, do we need to have approvals for patch 2/4 (arch/arm64/configs/defconfig)? I can easily take that in the HID tree, but I prefer having the approval from the maintainers first. Catalin, Will? > > Hrm, I just checked and there actually is already one merge conflict > with commit afdd34c5fa40 ("HID: i2c-hid: show the error when failing > to fetch the HID descriptor") but that commit (and thus the > resolution) is trivial. If there are no other comments I can re-post > atop that patch. ...or I'm also happy if a maintainer is OK w/ > resolving when landing my series. Just let me know! If I can quickly get the approval from the arm64/config maintainers, I can try to apply it. Though, I wouldn't be against you sending a clean and conflict-free series :) > > ...or, if you want me to just shut up for a while and wait until your > tryptophan hangover wears off, that's fine too--just let me know. > Heh. Sorry, I have a tendency to have my inbox flooded, and some time gets distracted to do other important work I am paid for (too). I don't mind a gentle nudge from time to time, that helps figuring out the priorities :) Cheers, Benjamin