From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: David Revoy <davidrevoy@protonmail.com>
Cc: "José Expósito" <jose.exposito89@gmail.com>,
"Eric GOUYER" <folays@gmail.com>,
"Illia Ostapyshyn" <ostapyshyn@sra.uni-hannover.de>,
jkosina@suse.cz, jason.gerecke@wacom.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Requesting your attention and expertise regarding a Tablet/Kernel issue
Date: Sat, 11 Nov 2023 09:52:21 +0100 [thread overview]
Message-ID: <CAO-hwJJ+nx72_TPfxcWRPBDZdDaPrO5yMNH4Y_mj6ej651Mesw@mail.gmail.com> (raw)
In-Reply-To: <7wmtNlKuYResf5cFQ7M2QTalzIUtw0I6ohvPcz69Jo1c8flezyIlnJu1IwAgXhJ-u0NlRL3IV7HnL0Kza6fVBqd7X7jhc-Z6QCi3oqHEvpY=@protonmail.com>
Hi David,
On Thu, Nov 9, 2023 at 11:04 PM David Revoy <davidrevoy@protonmail.com> wrote:
>
> Hi Benjamin,
>
> Thank you it works! 🎉 🎉 🎉
>
> > I've pushed an update of the file[0], turns out I made several mistakes.
> > As a general rule of thumb, you can follow the MR I've opened at [1],
> > click on the pipeline, open the last job ("make release"), then browse
> > the artifacts and pull the file from there.
> > [...]
> > > But just to be sure, you don't have a custom configuration in place
> > > for that tablet device?
> > [...]
> > [0] https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/jobs/51399392/artifacts/file/udev-hid-bpf_0.1.0.tar.xz
> > [1] https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/merge_requests/27
>
> I tested the latest artifact on kernel 6.5.8-200.fc38.x86_64 and I also removed my custom configuration at startup (I had not much: an hwdb files for the 24 Pro −mainly for frame buttons− and an xsetwacom bash script for each tablet).
>
> During the tests, the styluses of both 24 Pro and 16 Pro Gen2 worked perfectly: right-click on upper button out-of-the-box, and the eraser tip of the 16 Pro Gen2 continued to erase as expected.
While polishing the patches yesterday I realized that there was a bug
on the 24 Pro: it would never send proximity out events unless on a
very specific case: if you hold the pen perfectly vertical. This might
have an effect on the session and the pen behavior.
Could you please once again attach the hid-recorder of the Pro 24
while doing the following sequence:
- touch with the tip of the stylus the tablet
- while touching, press the upper button (the problematic one)
- still while touching, release the button
- remove the stylus
I need it to check what the device is sending when an "eraser mode
button" is pressed while the tip is touching the surface. Because I
think that's the only one problematic proximity out event as it would
"break" the current touch.
I have created another MR[2] to fix that, and I would appreciate it if
you could also give a test of the artifacts of job 51469284[3].
The points to check are:
- if you right click while touching the surface, do you still get only
a right click or some weird glitches in addition to it?
- if you right click while not touching (hovering), no glitches?
Cheers,
Benjamin
>
> I could also target with xsetwacom this 'button 3' of the styluses, and I tested random available shortcuts (but I'll keep default right-click).
>
> So, good job, and many thanks!
>
> I want now to write a follow-up after the first blog-post. I see it is a MR [1], maybe it means if it get merged it will be part of libevdev? What would you advice to write for the ones who want to benefit from the fix?
>
> Thanks again,
> David
>
> [1] https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/merge_requests/27
>
[2] https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/merge_requests/30
[3] https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/jobs/51469284
next prev parent reply other threads:[~2023-11-11 8:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <kRKTNDYigUSblpNgSuZ2H4dX03Of1yD4j_L9GgbyKXcDqZ67yh5HOQfcd7_83U3jZuQzxpKT3L6FXcRkkZIGdl_-PQF14oIB0QmRSfvpc2k=@protonmail.com>
2023-11-01 19:37 ` Requesting your attention and expertise regarding a Tablet/Kernel issue Jiri Kosina
2023-11-02 0:44 ` Bagas Sanjaya
2023-11-02 6:31 ` Linux regression tracking (Thorsten Leemhuis)
2023-11-02 7:51 ` Bagas Sanjaya
2023-11-02 7:44 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-12-01 8:24 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-11-03 20:05 ` Illia Ostapyshyn
2023-11-04 0:46 ` Bagas Sanjaya
2023-11-06 13:17 ` David Revoy
2023-11-06 16:59 ` Benjamin Tissoires
2023-11-06 20:06 ` Illia Ostapyshyn
2023-11-07 7:59 ` Benjamin Tissoires
2023-11-07 13:40 ` Illia Ostapyshyn
2023-11-08 5:23 ` Eric GOUYER
2023-11-08 9:04 ` Benjamin Tissoires
2023-11-08 9:23 ` José Expósito
2023-11-08 9:34 ` Benjamin Tissoires
2023-11-08 18:21 ` Benjamin Tissoires
2023-11-09 0:32 ` David Revoy
2023-11-09 11:56 ` Benjamin Tissoires
2023-11-09 16:13 ` Benjamin Tissoires
2023-11-09 22:04 ` David Revoy
2023-11-10 10:19 ` Benjamin Tissoires
2023-11-11 8:52 ` Benjamin Tissoires [this message]
2023-11-13 22:08 ` David Revoy
2023-11-14 14:35 ` Benjamin Tissoires
2023-11-15 15:14 ` Benjamin Tissoires
2023-11-23 22:12 ` David Revoy
2023-11-24 17:18 ` Benjamin Tissoires
2023-11-29 15:32 ` Benjamin Tissoires
2023-11-30 22:25 ` David Revoy
2023-12-01 15:41 ` Benjamin Tissoires
2023-11-08 19:40 ` Nils Fuhler
2023-11-08 20:34 ` Benjamin Tissoires
2023-11-08 22:31 ` ostapyshyn
2023-11-09 11:46 ` Benjamin Tissoires
2023-11-08 23:18 ` David Revoy
2023-11-09 11:47 ` Benjamin Tissoires
2023-11-11 17:15 ` Thorsten Leemhuis
2023-11-08 22:28 ` David Revoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO-hwJJ+nx72_TPfxcWRPBDZdDaPrO5yMNH4Y_mj6ej651Mesw@mail.gmail.com \
--to=benjamin.tissoires@redhat.com \
--cc=davidrevoy@protonmail.com \
--cc=folays@gmail.com \
--cc=jason.gerecke@wacom.com \
--cc=jkosina@suse.cz \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ostapyshyn@sra.uni-hannover.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).