From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0838AC433EF for ; Sat, 26 Feb 2022 09:19:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbiBZJUE (ORCPT ); Sat, 26 Feb 2022 04:20:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbiBZJUD (ORCPT ); Sat, 26 Feb 2022 04:20:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D8CB263727 for ; Sat, 26 Feb 2022 01:19:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645867168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BQWC4qnEcozjetIUZAtQHzyvu0e2sFoHBrXr/242A4Q=; b=Tebt/Jlh42UlaL03nqVeC5sy13NQG9FBNsir2Kn+HVmZjvBOB6SvvoBBpwlK13uUbNqWnp oUJKZiLn/Uhr/79gKp6SyTJ9gepkOiJtfOHSRii+GaVwaGgLJfjsYyNlU83cD0BZmdX5LL gMP74JPDy0sz40uXDglm1kZ/hQumzwU= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-212-Khf291XqMsisQe4Q4KoJSw-1; Sat, 26 Feb 2022 04:19:26 -0500 X-MC-Unique: Khf291XqMsisQe4Q4KoJSw-1 Received: by mail-pj1-f70.google.com with SMTP id c15-20020a17090a674f00b001bc9019ce17so4704579pjm.8 for ; Sat, 26 Feb 2022 01:19:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BQWC4qnEcozjetIUZAtQHzyvu0e2sFoHBrXr/242A4Q=; b=W3+FnPzjbLE8/RGjngtDh08bxYuZ9XCDNeHObdB3GSCqYNmGI2ugrXbhZEhGwO1d++ s5ZsAHIxgtyFo+SfyrD7awcIHGIZzEO26XKC7Yxx6QGBdjCeotiw50HCRp8XiG1SoX35 jAKlbvuTr9d7j5oHmkJhYQLfGnu4klzWySFbqil9a5Lm3PQFRnLRhb251UlEuOfYd4Tx Ci5F1hkjgOqimU+MnndRERGnOHgkckF4vaYQquZtvkBt8IsTe0WZiyvoZjqm7eLaY0m/ VsV5ppl3csKvyl4TS2WcwHB/EhZaEbJ3vgT6qZwgDIplVXsZiPsxWgm6lvqI6KPD4UvK nd5Q== X-Gm-Message-State: AOAM533u96AgELkQvBq1JuFRXrEggo/CHtiD8AsRM5ONplDCGRdbKjk8 +irJVnAEbXT9lGZ4rTaqzS94pJLOl4yACJ4j3S6oqWB6HttX0MynoSA2iSoS8EB8uhJe7MavkEd muRJquL3zCcGEPUl6QpcPF/QCAj4SnP1kYdJXZfs= X-Received: by 2002:a65:5bc3:0:b0:378:4f82:d73d with SMTP id o3-20020a655bc3000000b003784f82d73dmr4114562pgr.191.1645867165734; Sat, 26 Feb 2022 01:19:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdmbKJWHucKh9BWGgfnXQpcu4fvoXKQiGkxgHr4yoN9zm+Warf9dy1Ixf50NWclTqjqytmZTgZRWPfxr9pk+s= X-Received: by 2002:a65:5bc3:0:b0:378:4f82:d73d with SMTP id o3-20020a655bc3000000b003784f82d73dmr4114546pgr.191.1645867165532; Sat, 26 Feb 2022 01:19:25 -0800 (PST) MIME-Version: 1.0 References: <20220224110828.2168231-1-benjamin.tissoires@redhat.com> In-Reply-To: From: Benjamin Tissoires Date: Sat, 26 Feb 2022 10:19:14 +0100 Message-ID: Subject: Re: [PATCH bpf-next v1 0/6] Introduce eBPF support for HID devices To: Song Liu Cc: Greg KH , Jiri Kosina , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Shuah Khan , Dave Marchevsky , Joe Stringer , Tero Kristo , lkml , "open list:HID CORE LAYER" , Networking , bpf , linux-kselftest@vger.kernel.org, Peter Hutterer Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sat, Feb 26, 2022 at 8:37 AM Song Liu wrote: > > On Fri, Feb 25, 2022 at 8:32 AM Greg KH wrote: > > > [...] > > > > One comment about the patch series. You might want to break the patches > > up a bit smaller, having the example code in a separate commit from the > > "add this feature" commit, as it was hard to pick out what was kernel > > changes, and what was test changes from it. That way I can complain > > about the example code and tests without having to worry about the > > kernel patches. > > Echo on this part. Please organize kernel changes, libbpf changes, > maybe also bpftool changes, selftests, and samples into separate patches. > This would help folks without HID experience understand the design. > Sure. And thanks for the initial review. I'll send out a splitted v2 early next week then. Cheers, Benjamin