From: Anson Huang <anson.huang@nxp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Cc: Robin van der Gracht <robin@protonic.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
Date: Tue, 26 Nov 2019 00:40:54 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916D29B5D0D6D3E849138E4F5450@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191125211407.GA97812@dtor-ws>
> Subject: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
>
> Gratuitous NULL initializers rarely help and often prevent compiler from
> warning about using uninitialized variable. Let's remove them.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> b/drivers/input/keyboard/snvs_pwrkey.c
> index fd6f244f403d..2f5e3ab5ed63 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
>
> static int imx_snvs_pwrkey_probe(struct platform_device *pdev) {
> - struct pwrkey_drv_data *pdata = NULL;
> - struct input_dev *input = NULL;
> + struct pwrkey_drv_data *pdata;
> + struct input_dev *input;
> struct device_node *np;
> int error;
> u32 vid;
> --
> 2.24.0.432.g9d3f5f5b63-goog
>
>
> --
> Dmitry
prev parent reply other threads:[~2019-11-26 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 21:14 [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers Dmitry Torokhov
2019-11-26 0:40 ` Anson Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916D29B5D0D6D3E849138E4F5450@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).