From: Roy Im <roy.im.opensource@diasemi.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Roy Im <roy.im.opensource@diasemi.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Brian Masney <masneyb@onstation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>, Luca Weiss <luca@z3ntu.xyz>,
Maximilian Luz <luzmaximilian@gmail.com>,
Pascal PAILLET-LME <p.paillet@st.com>,
Rob Herring <robh@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Support Opensource <Support.Opensource@diasemi.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: RE: [PATCH v15 3/3] Input: new da7280 haptic driver
Date: Tue, 30 Jun 2020 03:39:26 +0000 [thread overview]
Message-ID: <DB8PR10MB3356EF71023E587911611C0C856F0@DB8PR10MB3356.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <602a5743-d27b-3e81-e917-d343f58d35e9@infradead.org>
On Tue, June 30, 2020 12:14 PM, Randy Dunlap wrote:
> On 6/29/20 6:01 AM, Roy Im wrote:
> > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> > index 362e8a0..79fbddb 100644
> > --- a/drivers/input/misc/Kconfig
> > +++ b/drivers/input/misc/Kconfig
> > @@ -869,4 +869,17 @@ config INPUT_STPMIC1_ONKEY
> > To compile this driver as a module, choose M here: the
> > module will be called stpmic1_onkey.
> >
> > +config INPUT_DA7280_HAPTICS
> > + tristate "Dialog Semiconductor DA7280 haptics support"
> > + depends on INPUT && I2C
> > + select INPUT_FF_MEMLESS
> > + select REGMAP_I2C
> > + help
> > + Say Y to enable support for the Dialog DA7280 haptics driver.
> > + The haptics can be controlled by i2c communication,
>
> If you make any more updates, make this: I2C communication,
> please.
OK, I will do. Thanks for your comment.
>
> > + or by PWM input, or by GPI.
> > +
> > + To compile this driver as a module, choose M here: the
> > + module will be called da7280.
> > +
> > endif
>
> thanks.
> --
> ~Randy
next prev parent reply other threads:[~2020-06-30 3:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 13:01 [PATCH v15 0/3] da7280: haptic driver submission Roy Im
2020-06-29 13:01 ` [PATCH v15 2/3] dt-bindings: input: Add document bindings for DA7280 Roy Im
2020-06-29 13:01 ` [PATCH v15 3/3] Input: new da7280 haptic driver Roy Im
2020-06-30 3:13 ` Randy Dunlap
2020-06-30 3:39 ` Roy Im [this message]
2020-07-02 18:01 ` Jes Sorensen
2020-07-03 6:50 ` Roy Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR10MB3356EF71023E587911611C0C856F0@DB8PR10MB3356.EURPRD10.PROD.OUTLOOK.COM \
--to=roy.im.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=luzmaximilian@gmail.com \
--cc=masneyb@onstation.org \
--cc=p.paillet@st.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).