From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe
Date: Thu, 12 Nov 2020 06:51:05 +0000 [thread overview]
Message-ID: <DM6PR03MB44112F9E87F383E0B727D83DF9E70@DM6PR03MB4411.namprd03.prod.outlook.com> (raw)
In-Reply-To: <DM6PR03MB4411AC5AC6EC2F0F4337A05CF9E70@DM6PR03MB4411.namprd03.prod.outlook.com>
> -----Original Message-----
> From: Ardelean, Alexandru
> Sent: Thursday, November 12, 2020 8:40 AM
> To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe
>
>
> > -----Original Message-----
> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Sent: Thursday, November 12, 2020 2:38 AM
> > To: Ardelean, Alexandru <alexandru.Ardelean@analog.com>
> > Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for
> > error in probe
> >
> > [External]
> >
> > Hi Alexandru,
> >
> > On Wed, Nov 11, 2020 at 10:48:28AM +0200, Alexandru Ardelean wrote:
> > > The 'error' & 'ret' variables are used. This is a bit of duplication.
> > > This change replaces the use of error with the 'ret' variable since
> > > the name is a bit more generic.
> >
> > I really prefer variables that carry error codes/success and are used
> > in error paths to be called "error", and "ret" or "retval" to be used
> > in cases where we may return actual data.
> >
>
> Ack.
> Will do it the other way around for v2.
>
Wait.
I just had some coffee.
I think you're saying to drop this patch.
Also fine from my side.
> > Thanks.
> >
> > --
> > Dmitry
next prev parent reply other threads:[~2020-11-12 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 8:48 [PATCH 0/6] Input: adp5589: cleanup and use device-managed functions Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 1/6] Input: adp5589: use a single variable for error in probe Alexandru Ardelean
2020-11-12 0:37 ` Dmitry Torokhov
2020-11-12 6:39 ` Ardelean, Alexandru
2020-11-12 6:51 ` Ardelean, Alexandru [this message]
2020-11-11 8:48 ` [PATCH 2/6] Input: adp5589: use devm_kzalloc() to allocate the kpad object Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 3/6] Input: adp5589: use device-managed function in adp5589_keypad_add() Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 4/6] Input: adp5589: remove setup/teardown hooks for gpios Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 5/6] Input: adp5589: use devm_gpiochip_add_data() " Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 6/6] Input: adp5589: use devm_add_action_or_reset() for register clear Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR03MB44112F9E87F383E0B727D83DF9E70@DM6PR03MB4411.namprd03.prod.outlook.com \
--to=alexandru.ardelean@analog.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).