From: Horia Geanta <horia.geanta@nxp.com>
To: Robin Gong <yibin.gong@nxp.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "André Draszik" <git@andred.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Anson Huang" <anson.huang@nxp.com>,
"Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed
Date: Mon, 10 Feb 2020 06:33:30 +0000 [thread overview]
Message-ID: <VI1PR0402MB34851857F012286250BF3BBE98190@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: VE1PR04MB6638A4F4E3BABE0ED0CD4A5189190@VE1PR04MB6638.eurprd04.prod.outlook.com
On 2/10/2020 4:03 AM, Robin Gong wrote:
> On 2020/02/10 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>> On Fri, Feb 07, 2020 at 08:10:22AM +0000, Horia Geanta wrote:
>>> On 1/30/2020 10:45 PM, André Draszik wrote:
>>>> @@ -140,6 +148,25 @@ static int imx_snvs_pwrkey_probe(struct
>> platform_device *pdev)
>>>> if (pdata->irq < 0)
>>>> return -EINVAL;
>>>>
>>>> + pdata->clk = devm_clk_get(&pdev->dev, "snvs-pwrkey");
>>>> + if (IS_ERR(pdata->clk)) {
>>>> + pdata->clk = NULL;
>>> Using devm_clk_get_optional() would simplify error handling.
>>
>> It sounds to me that this clock is not at all optional and the driver currently
>> "works" only by accident and therefore optional is not suitable here.
> Yes, then we need to add all snvs clk in dts for on legacy i.MX chips in this patchset
> to avoid any potential function broken.
In that case the DT binding should be updated too,
to make the clock mandatory.
But before doing this all i.MX SoCs should be checked.
Thanks,
Horia
next prev parent reply other threads:[~2020-02-10 6:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 20:45 [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey André Draszik
2020-01-30 20:45 ` [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed André Draszik
2020-02-07 8:10 ` Horia Geanta
2020-02-09 22:38 ` Dmitry Torokhov
2020-02-10 2:03 ` Robin Gong
2020-02-10 6:33 ` Horia Geanta [this message]
2020-02-10 17:55 ` Dmitry Torokhov
2020-02-11 1:54 ` Robin Gong
2020-02-11 9:13 ` André Draszik
2020-02-12 0:58 ` Robin Gong
2020-01-30 20:45 ` [PATCH 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events André Draszik
2020-02-06 18:30 ` [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey Rob Herring
2020-02-07 7:36 ` Horia Geanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB34851857F012286250BF3BBE98190@VI1PR0402MB3485.eurprd04.prod.outlook.com \
--to=horia.geanta@nxp.com \
--cc=anson.huang@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=git@andred.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).