From: BOUGH CHEN <haibo.chen@nxp.com>
To: BOUGH CHEN <haibo.chen@nxp.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/2] input: egalax_ts: switch to i2c interface before wake up
Date: Tue, 10 Mar 2020 01:58:49 +0000 [thread overview]
Message-ID: <VI1PR04MB5040BE3CE3413B12A252372F90FF0@VI1PR04MB5040.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1581410472-3225-1-git-send-email-haibo.chen@nxp.com>
Ping...
Hi Dmitry,
Can you help review these two patches?
Haibo Chen
> -----Original Message-----
> From: haibo.chen@nxp.com <haibo.chen@nxp.com>
> Sent: 2020年2月11日 16:41
> To: dmitry.torokhov@gmail.com; linux-input@vger.kernel.org
> Cc: BOUGH CHEN <haibo.chen@nxp.com>; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: [PATCH 1/2] input: egalax_ts: switch to i2c interface before wake up
>
> From: Haibo Chen <haibo.chen@nxp.com>
>
> For HannStar (HSD100PXN1 Rev: 1-A00C11 F/W:0634) LVDS touch screen, it
> has a special request for the EETI touch controller. The host needs to trigger
> I2C event to device FW at booting first, and then the FW can switch to I2C
> interface. Otherwise, the FW can’t work with I2C interface, and can't
> generate any interrupt when touch the screen.
>
> This patch send an I2C command before the device wake up, make sure the
> device switch to I2C interface first.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> drivers/input/touchscreen/egalax_ts.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/input/touchscreen/egalax_ts.c
> b/drivers/input/touchscreen/egalax_ts.c
> index 83ac8c128192..5e35ca5edc7b 100644
> --- a/drivers/input/touchscreen/egalax_ts.c
> +++ b/drivers/input/touchscreen/egalax_ts.c
> @@ -183,6 +183,20 @@ static int egalax_ts_probe(struct i2c_client *client,
> ts->client = client;
> ts->input_dev = input_dev;
>
> + /* HannStar (HSD100PXN1 Rev: 1-A00C11 F/W:0634) LVDS touch
> + * screen needs to trigger I2C event to device FW at booting
> + * first, and then the FW can switch to I2C interface.
> + * Otherwise, the FW can’t work with I2C interface. So here
> + * just use the exist function egalax_firmware_version() to
> + * send a I2C command to the device, make sure the device FW
> + * switch to I2C interface.
> + */
> + error = egalax_firmware_version(client);
> + if (error) {
> + dev_err(&client->dev, "Failed to switch to I2C interface\n");
> + return error;
> + }
> +
> /* controller may be in sleep, wake it up. */
> error = egalax_wake_up_device(client);
> if (error) {
> --
> 2.17.1
next prev parent reply other threads:[~2020-03-10 1:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 8:41 [PATCH 1/2] input: egalax_ts: switch to i2c interface before wake up haibo.chen
2020-02-11 8:41 ` [PATCH 2/2] input: egalax_ts: free irq resource before request the line as GPIO haibo.chen
2020-03-10 4:26 ` Dmitry Torokhov
2020-03-10 7:15 ` BOUGH CHEN
2020-04-19 18:10 ` Dmitry Torokhov
2020-04-19 21:27 ` Andy Shevchenko
2020-04-28 11:21 ` Linus Walleij
2020-03-10 1:58 ` BOUGH CHEN [this message]
2020-03-10 4:22 ` [PATCH 1/2] input: egalax_ts: switch to i2c interface before wake up Dmitry Torokhov
2020-03-10 7:01 ` BOUGH CHEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5040BE3CE3413B12A252372F90FF0@VI1PR04MB5040.eurprd04.prod.outlook.com \
--to=haibo.chen@nxp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).