* [PATCH] input: sun4i-lradc-keys - Add wakup support
@ 2021-01-03 10:54 Samuel Holland
2021-01-03 22:53 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2021-01-03 10:54 UTC (permalink / raw)
To: Hans de Goede, Dmitry Torokhov, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec
Cc: linux-input, linux-kernel, linux-sunxi, Ondrej Jirman, Samuel Holland
From: Ondrej Jirman <megous@megous.com>
Allow the driver to wake up the system on key press. Since using the
LRADC as a wakeup source requires keeping on an additional power domain,
disable the wakeup source by default.
Signed-off-by: Ondrej Jirman <megous@megous.com>
[Samuel: disable the wakeup source by default]
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/input/keyboard/sun4i-lradc-keys.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index 4a796bed48ac..4d0e8879a97d 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -22,6 +22,8 @@
#include <linux/module.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
+#include <linux/pm_wakeirq.h>
+#include <linux/pm_wakeup.h>
#include <linux/regulator/consumer.h>
#include <linux/slab.h>
@@ -226,8 +228,7 @@ static int sun4i_lradc_probe(struct platform_device *pdev)
{
struct sun4i_lradc_data *lradc;
struct device *dev = &pdev->dev;
- int i;
- int error;
+ int error, i, irq;
lradc = devm_kzalloc(dev, sizeof(struct sun4i_lradc_data), GFP_KERNEL);
if (!lradc)
@@ -272,8 +273,13 @@ static int sun4i_lradc_probe(struct platform_device *pdev)
if (IS_ERR(lradc->base))
return PTR_ERR(lradc->base);
- error = devm_request_irq(dev, platform_get_irq(pdev, 0),
- sun4i_lradc_irq, 0,
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ dev_err(&pdev->dev, "Failed to get IRQ\n");
+ return irq;
+ }
+
+ error = devm_request_irq(dev, irq, sun4i_lradc_irq, 0,
"sun4i-a10-lradc-keys", lradc);
if (error)
return error;
@@ -282,6 +288,14 @@ static int sun4i_lradc_probe(struct platform_device *pdev)
if (error)
return error;
+ device_set_wakeup_capable(dev, true);
+
+ error = dev_pm_set_wake_irq(dev, irq);
+ if (error) {
+ dev_err(dev, "Could not set wake IRQ\n");
+ return error;
+ }
+
return 0;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: sun4i-lradc-keys - Add wakup support
2021-01-03 10:54 [PATCH] input: sun4i-lradc-keys - Add wakup support Samuel Holland
@ 2021-01-03 22:53 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-01-03 22:53 UTC (permalink / raw)
To: Samuel Holland
Cc: Hans de Goede, Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec,
linux-input, linux-kernel, linux-sunxi, Ondrej Jirman
Hi Samuel,
On Sun, Jan 03, 2021 at 04:54:46AM -0600, Samuel Holland wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Allow the driver to wake up the system on key press. Since using the
> LRADC as a wakeup source requires keeping on an additional power domain,
> disable the wakeup source by default.
Why isn't this controlled via DT property? wakeup-source?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-03 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03 10:54 [PATCH] input: sun4i-lradc-keys - Add wakup support Samuel Holland
2021-01-03 22:53 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).