From: Dmitry Torokhov <email@example.com> To: Furquan Shaikh <firstname.lastname@example.org> Cc: Dan Carpenter <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v2] input: raydium_ts_i2c: Do not split tx transactions Date: Sun, 6 Dec 2020 22:20:05 -0800 [thread overview] Message-ID: <X83Jld+Ga1ahuve2@google.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, Dec 04, 2020 at 04:59:41PM -0800, Furquan Shaikh wrote: > Raydium device does not like splitting of tx transactions into > multiple messages - one for the register address and one for the > actual data. This results in incorrect behavior on the device side. > > This change updates raydium_i2c_read and raydium_i2c_write to create > i2c_msg arrays separately and passes those arrays into > raydium_i2c_xfer which decides based on the address whether the bank > switch command should be sent. The bank switch header is still added > by raydium_i2c_read and raydium_i2c_write to ensure that all these > operations are performed as part of a single I2C transfer. It > guarantees that no other transactions are initiated to any other > device on the same bus after the bank switch command is sent. > > Signed-off-by: Furquan Shaikh <email@example.com> Applied, thank you. -- Dmitry
prev parent reply other threads:[~2020-12-07 6:21 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-01 6:00 [PATCH] " Furquan Shaikh 2020-12-01 6:28 ` Dmitry Torokhov 2020-12-01 6:54 ` Furquan Shaikh 2020-12-01 7:06 ` Dmitry Torokhov 2020-12-01 7:15 ` Furquan Shaikh 2020-12-05 0:59 ` [PATCH v2] " Furquan Shaikh 2020-12-07 6:20 ` Dmitry Torokhov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X83Jld+Ga1ahuve2@google.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2] input: raydium_ts_i2c: Do not split tx transactions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).