From: Will McVicker <email@example.com> To: Greg KH <firstname.lastname@example.org> Cc: Jiri Kosina <email@example.com>, Benjamin Tissoires <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Will Coster <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH v1] HID: make arrays usage and value to be the same Date: Mon, 7 Dec 2020 09:55:48 -0800 [thread overview] Message-ID: <X85spIzp1/gRxvKr@google.com> (raw) In-Reply-To: <X8tMDQTls/RcTSAy@kroah.com> On Sat, Dec 05, 2020 at 09:59:57AM +0100, Greg KH wrote: > On Sat, Dec 05, 2020 at 12:48:48AM +0000, Will McVicker wrote: > > The HID subsystem allows an "HID report field" to have a different > > number of "values" and "usages" when it is allocated. When a field > > struct is created, the size of the usage array is guaranteed to be at > > least as large as the values array, but it may be larger. This leads to > > a potential out-of-bounds write in > > __hidinput_change_resolution_multipliers() and an out-of-bounds read in > > hidinput_count_leds(). > > > > To fix this, let's make sure that both the usage and value arrays are > > the same size. > > > > Signed-off-by: Will McVicker <email@example.com> > > Any reason not to also add a cc: stable on this? No reason not to include stable. CC'd here. > > And, has this always been the case, or was this caused by some specific > commit in the past? If so, a "Fixes:" tag is always nice to included. I dug into the history and it's been like this for the past 10 years. So yeah pretty much always like this. > > And finally, as you have a fix for this already, no need to cc: > firstname.lastname@example.org as there's nothing the people there can do about it now :) Is that short for email@example.com? If yes, then I did include them. If no, do you mind explaining? > > thanks, > > greg k-h
next prev parent reply other threads:[~2020-12-07 17:56 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-05 0:48 Will McVicker 2020-12-05 8:59 ` Greg KH 2020-12-07 17:55 ` Will McVicker [this message] 2020-12-07 18:24 ` Greg KH 2020-12-07 19:05 ` Will McVicker 2020-12-14 19:15 ` Will McVicker 2020-12-17 10:19 ` Jiri Kosina 2020-12-17 18:42 ` Will McVicker 2021-01-14 18:19 ` Will McVicker 2021-01-18 8:11 ` Jiri Kosina
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X85spIzp1/gRxvKr@google.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v1] HID: make arrays usage and value to be the same' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).