From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Russell King <linux@armlinux.org.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Alan Stern <stern@rowland.harvard.edu>,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void
Date: Fri, 4 Dec 2020 15:58:17 +0100 [thread overview]
Message-ID: <X8pOiU2a6BjfFuov@kroah.com> (raw)
In-Reply-To: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de>
On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-König wrote:
> The driver core ignores the return value of struct device_driver::remove
> because there is only little that can be done. To simplify the quest to
> make this function return void, let struct sa1111_driver::remove return
> void, too. All users already unconditionally return 0, this commit makes
> it obvious that returning an error code is a bad idea and ensures future
> users behave accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-12-04 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 11:47 [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Uwe Kleine-König
2020-12-02 3:15 ` Dmitry Torokhov
2020-12-04 14:58 ` Greg Kroah-Hartman [this message]
2020-12-04 20:09 ` Uwe Kleine-König
2020-12-05 8:23 ` Greg Kroah-Hartman
2020-12-05 8:26 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8pOiU2a6BjfFuov@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=stern@rowland.harvard.edu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).