linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux Input <linux-input@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: Input: tm2-touchkey - document vddio-supply
Date: Sun, 6 Dec 2020 13:28:14 +0100	[thread overview]
Message-ID: <X8zOXpJ7fjIlgtnP@gerhold.net> (raw)
In-Reply-To: <CACRpkdadiyYK5i8+TaLqxjmp4mUJ8eTiyZkgPXp-Qa2+CD8DrA@mail.gmail.com>

On Sun, Dec 06, 2020 at 12:09:50AM +0100, Linus Walleij wrote:
> On Thu, Dec 3, 2020 at 2:13 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> 
> > The Samsung touchkey controllers are often used with external pull-up
> > for the interrupt line and the I2C lines, so we might need to enable
> > a regulator to bring the lines into usable state. Otherwise, this might
> > cause spurious interrupts and reading from I2C will fail.
> >
> > Document support for a "vddio-supply" that is enabled by the tm2-touchkey
> > driver so that the regulator gets enabled when needed.
> >
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> > +  vddio-supply:
> > +    description: |
> > +      Optional regulator that provides digital I/O voltage,
> > +      e.g. for pulling up the interrupt line or the I2C pins.
> 
> I think the funny pipe | us only needed when you want something to be
> fixed-width like ASCII art or ASCII tables. But no big deal I suppose.
> 

Actually, the pipe | effectively means that new lines \n will be
preserved in the parsed output, i.e.

  something:
    Hello
    World

means "Hello World", while

  something: |
    Hello
    World

means "Hello\nWorld\n".

In practice I guess it doesn't make much of a difference for these
descriptions. It also doesn't seem to be used very consistently in
existing device tree bindings, so I think it's fine as-is.

Thanks,
Stephan

  reply	other threads:[~2020-12-06 12:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 13:12 [PATCH 1/3] dt-bindings: Input: tm2-touchkey - convert to yaml Stephan Gerhold
2020-12-03 13:12 ` [PATCH 2/3] dt-bindings: Input: tm2-touchkey - document vddio-supply Stephan Gerhold
2020-12-05 23:09   ` Linus Walleij
2020-12-06 12:28     ` Stephan Gerhold [this message]
2020-12-06 15:10       ` Linus Walleij
2020-12-09 20:12   ` Rob Herring
2020-12-10  3:50   ` Dmitry Torokhov
2020-12-03 13:12 ` [PATCH 3/3] Input: tm2-touchkey - add vddio regulator Stephan Gerhold
2020-12-05 23:10   ` Linus Walleij
2020-12-10  3:51   ` Dmitry Torokhov
2020-12-05 23:08 ` [PATCH 1/3] dt-bindings: Input: tm2-touchkey - convert to yaml Linus Walleij
2020-12-09 20:12 ` Rob Herring
2020-12-10  3:50 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X8zOXpJ7fjIlgtnP@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 2/3] dt-bindings: Input: tm2-touchkey - document vddio-supply' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).