From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
Nemo Han <nemo.han@unisoc.com>
Subject: Re: [PATCH v2 1/3] input: sc27xx: Add support for sc2730 and sc2721
Date: Fri, 11 Dec 2020 19:04:13 -0800 [thread overview]
Message-ID: <X9QzLcbk8ZrWbFH9@google.com> (raw)
In-Reply-To: <20201117034949.47877-2-zhang.lyra@gmail.com>
Hi Chunyan,
On Tue, Nov 17, 2020 at 11:49:47AM +0800, Chunyan Zhang wrote:
> @@ -78,8 +112,15 @@ static void sc27xx_vibra_close(struct input_dev *input)
> static int sc27xx_vibra_probe(struct platform_device *pdev)
> {
> struct vibra_info *info;
> + const struct sc27xx_vibra_data *data;
> int error;
>
> + data = of_device_get_match_data(&pdev->dev);
> + if (!data) {
> + dev_err(&pdev->dev, "no matching driver data found\n");
> + return -EINVAL;
> + }
This does not have to be OF-specific, so I changed it to
device_get_match_data() and applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2020-12-12 3:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 3:49 [PATCH v2 0/3] Add support for sc2730 and sc2721 Chunyan Zhang
2020-11-17 3:49 ` [PATCH v2 1/3] input: sc27xx: " Chunyan Zhang
2020-12-12 3:04 ` Dmitry Torokhov [this message]
2020-11-17 3:49 ` [PATCH v2 2/3] dt-bindings: input: Convert sc27xx-vibra.txt to json-schema Chunyan Zhang
2020-12-07 19:35 ` Rob Herring
2020-12-12 3:00 ` Dmitry Torokhov
2020-11-17 3:49 ` [PATCH v2 3/3] dt-bindings: input: Add compatible string for SC2721 and SC2730 Chunyan Zhang
2020-12-07 19:35 ` Rob Herring
2020-12-12 3:01 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9QzLcbk8ZrWbFH9@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nemo.han@unisoc.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).