From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeffrey Lin <jeffrey.lin@raydium.corp-partner.google.com>
Cc: Furquan Shaikh <furquan@google.com>,
Sean Paul <seanpaul@chromium.org>,
rrangel@chromium.org, dan.carpenter@oracle.com,
jeffrey.lin@rad-ic.com, KP.li@rad-ic.com,
calvin.tseng@rad-ic.com, simba.hsu@rad-ic.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: raydium_ts_i2c: Do not send zero length
Date: Mon, 14 Dec 2020 22:27:58 -0800 [thread overview]
Message-ID: <X9hXbmn1gxxPEKVS@google.com> (raw)
In-Reply-To: <CAGdSJX2esa41ypqhGGVSJn+Yqxz8gTyz4HYmfB4WfVDEJLgVYw@mail.gmail.com>
On Tue, Dec 15, 2020 at 02:07:00PM +0800, Jeffrey Lin wrote:
> Yes, it is.
Great!
>
> Dmitry Torokhov <dmitry.torokhov@gmail.com> 於 2020年12月15日 週二 下午1:48寫道:
>
> > Hi Jeffrey,
> >
> > On Tue, Dec 15, 2020 at 11:21:06AM +0800, jeffrey.lin wrote:
> > > Add default write command package to prevent i2c quirk error of zero
> > > data length as Raydium touch firmware update is executed.
> > >
> > > Signed-off-by: jeffrey.lin <jeffrey.lin@rad-ic.com>
> > > BUG=b:174207906
> > > TEST=Successfully tested update Raydium touch firmware over 100 times
> > > Change-Id: I311b0d26d7642bb800547cd0e87013be17cb7e1b
Could you please drop these BUG/TEST/Change-Id and re-send from your
main account (jeffrey.lin@rad-ic.com)? Or simply add "From:" tag:
From: Jeffrey Lin <jeffrey.lin@rad-ic.com>
> > > ---
> > > drivers/input/touchscreen/raydium_i2c_ts.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c
> > b/drivers/input/touchscreen/raydium_i2c_ts.c
> > > index 603a948460d64..4d2d22a869773 100644
> > > --- a/drivers/input/touchscreen/raydium_i2c_ts.c
> > > +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
> > > @@ -445,6 +445,7 @@ static int raydium_i2c_write_object(struct
> > i2c_client *client,
> > > enum raydium_bl_ack state)
> > > {
> > > int error;
> > > + static const u8 cmd[] = { 0xFF, 0x39 };
> > >
> > > error = raydium_i2c_send(client, RM_CMD_BOOT_WRT, data, len);
> > > if (error) {
> > > @@ -453,7 +454,7 @@ static int raydium_i2c_write_object(struct
> > i2c_client *client,
> > > return error;
> > > }
> > >
> > > - error = raydium_i2c_send(client, RM_CMD_BOOT_ACK, NULL, 0);
> > > + error = raydium_i2c_send(client, RM_CMD_BOOT_ACK, cmd,
> > sizeof(cmd));
> >
> > Is this supported by all firmwares?
> >
> > > if (error) {
> > > dev_err(&client->dev, "Ack obj command failed: %d\n",
> > error);
> > > return error;
> > > --
> > > 2.26.2
> > >
> >
> > Thanks.
> >
> > --
> > Dmitry
> >
Thanks!
--
Dmitry
next prev parent reply other threads:[~2020-12-15 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 3:21 [PATCH] Input: raydium_ts_i2c: Do not send zero length jeffrey.lin
2020-12-15 5:48 ` Dmitry Torokhov
[not found] ` <CAGdSJX2esa41ypqhGGVSJn+Yqxz8gTyz4HYmfB4WfVDEJLgVYw@mail.gmail.com>
2020-12-15 6:27 ` Dmitry Torokhov [this message]
2020-12-15 11:20 jeffrey.lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9hXbmn1gxxPEKVS@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=KP.li@rad-ic.com \
--cc=calvin.tseng@rad-ic.com \
--cc=dan.carpenter@oracle.com \
--cc=furquan@google.com \
--cc=jeffrey.lin@rad-ic.com \
--cc=jeffrey.lin@raydium.corp-partner.google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=seanpaul@chromium.org \
--cc=simba.hsu@rad-ic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).