Re: [PATCH] Input: gtco - remove driver

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Paul Hollinsky <phollinsky@holtechnik.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: gtco - remove driver
Date: Thu, 17 Dec 2020 22:53:51 -0800	[thread overview]
Message-ID: <X9xR/wTjU1tLS5JV@google.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2012171221350.25826@cbobk.fhfr.pm>

Hi Jiri,

On Thu, Dec 17, 2020 at 12:22:17PM +0100, Jiri Kosina wrote:
> On Sat, 5 Dec 2020, Dmitry Torokhov wrote:
> 
> > The driver has its own HID descriptor parsing code, that had and still
> > has several issues discovered by syzbot and other tools. Ideally we
> > should move the driver over to the HID subsystem, so that it uses proven
> > parsing code.  However the devices in question are EOL, and GTCO is not
> > willing to extend resources for that, so let's simply remove the driver.
> 
> Acked-by: Jiri Kosina <jkosina@suse.cz>
> 
> > 
> > Note that our HID support has greatly improved over the last 10 years,
> > we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO
> > CalComp Digitizers and InterWrite School Products to blacklist") and see
> > if GTCO devices actually work with normal HID drivers.
> 
> Sounds like a good plan to me. Perhaps you can do that in a series 
> together, and stage that for 5.12?

Sorry, I already zapped the driver in 5.11.

Unfortunately I do not have this hardware, so while we could remove
these devices from the blacklist we will have to do that blindly. Please
let me know if you still want to do that.

Thank you.

-- 
Dmitry