From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82E3C4332D for ; Thu, 31 Dec 2020 00:09:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9860C207AB for ; Thu, 31 Dec 2020 00:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgLaAJh (ORCPT ); Wed, 30 Dec 2020 19:09:37 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:52492 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgLaAJh (ORCPT ); Wed, 30 Dec 2020 19:09:37 -0500 Date: Thu, 31 Dec 2020 00:08:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609373335; bh=Z0qWUIjYFPtB/T1kZy/Bw0QDTjHrrjuhAfqUPxKNIjU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=PotkNgBdLaSzi1gtwGCtFB9KA5QAZb3Fcx+19zuM1KL/pdrMGj9TjaiXIEWntxkto pSghK0Le+WsQxXpGqNI+gFhd9sjuCvt+kpKWvrp/gFJzPJ4sa22rqFALMJ/OT+JabU eNBm8cywzTFpSySKh+vX4LgJlw987VQeU5lM2U8g= To: Roderick Colenbrander From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jiri Kosina , Benjamin Tissoires , "linux-input@vger.kernel.org" , Chris Ye , Roderick Colenbrander Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Subject: Re: [PATCH 01/13] HID: playstation: initial DualSense USB support. Message-ID: In-Reply-To: <20201219062336.72568-2-roderick@gaikai.com> References: <20201219062336.72568-1-roderick@gaikai.com> <20201219062336.72568-2-roderick@gaikai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi 2020. december 19., szombat 7:23 keltez=C3=A9ssel, Roderick Colenbrander = =C3=ADrta: > [...] > +static const struct hid_device_id ps_devices[] =3D { > +=09{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS5_CONTROLLE= R), > +=09=09.driver_data =3D 0 }, > +}; > [...] I have come across an AUR package [1], and looking at the modifications app= lied there (work-without-modifying-hid-quirks.patch), I think should be a termin= ating entry in this array. And maybe `MODULE_DEVICE_TABLE()` is also missing? [1]: https://aur.archlinux.org/packages/hid-playstation-dkms/ Regards, Barnab=C3=A1s P=C5=91cze