From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Luca Ellero <luca.ellero@brickedbrain.com>
Cc: Luca Ellero <l.ellero@asem.it>,
dmitry.torokhov@gmail.com, daniel@zonque.org,
m.felsch@pengutronix.de, u.kleine-koenig@pengutronix.de,
mkl@pengutronix.de, miquel.raynal@bootlin.com,
imre.deak@nokia.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: ads7846 - don't report pressure for ads7845
Date: Mon, 23 Jan 2023 14:25:06 +0200 [thread overview]
Message-ID: <Y858otTEDM1ugI0k@smile.fi.intel.com> (raw)
In-Reply-To: <74c917ce-a67c-7b4a-023b-2f2f4fb365b5@brickedbrain.com>
On Mon, Jan 23, 2023 at 09:27:37AM +0100, Luca Ellero wrote:
> On 20/01/2023 16:16, Andy Shevchenko wrote:
> > On Fri, Jan 20, 2023 at 01:45:42PM +0100, Luca Ellero wrote:
> > > ADS7845 doesn't support pressure.
> > > This patch avoids the following error reported by libinput-list-devices:
> >
> > s/This patch avoids/Avoid/
> >
> > (This rule is written in Submitting Patches documentation.)
> >
> > > "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE".
> >
> > Do you need a Fixes tag?
> >
>
> Hi Andy,
> thank you for your reply.
> I haven't found a specific bug report to apply to this patches.
> Could you kindly provide a "Fixes:" tag that I can apply?
The Fixes tag in accordance with the documentation should refer to the commit
in the Git history which brought the problem (regression).
> It's more like this driver has never been tested with ADS7845.
> Maybe the patches should be considered as a new implementation instead than
> a bug fix?
If it's indeed from day 1, then the initial commit can be considered as Fixes
tag, but I leave it to maintainer to decide.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-23 12:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 12:45 [PATCH v4 0/3] Input: ads7846 - fix support for ADS7845 Luca Ellero
2023-01-20 12:45 ` [PATCH 1/3] Input: ads7846 - don't report pressure for ads7845 Luca Ellero
2023-01-20 15:16 ` Andy Shevchenko
2023-01-23 8:27 ` Luca Ellero
2023-01-23 12:25 ` Andy Shevchenko [this message]
2023-01-24 8:40 ` Luca Ellero
2023-01-20 12:45 ` [PATCH 2/3] Input: ads7846 - always set last command to PWRDOWN Luca Ellero
2023-01-20 15:17 ` Andy Shevchenko
2023-01-20 12:45 ` [PATCH 3/3] Input: ads7846 - don't check penirq immediately for 7845 Luca Ellero
2023-01-20 15:18 ` Andy Shevchenko
2023-01-20 15:18 ` [PATCH v4 0/3] Input: ads7846 - fix support for ADS7845 Andy Shevchenko
2023-01-26 10:52 [PATCH v5 " Luca Ellero
2023-01-26 10:52 ` [PATCH 1/3] Input: ads7846 - don't report pressure for ads7845 Luca Ellero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y858otTEDM1ugI0k@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=imre.deak@nokia.com \
--cc=l.ellero@asem.it \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ellero@brickedbrain.com \
--cc=m.felsch@pengutronix.de \
--cc=miquel.raynal@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).