From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Jesse Taube <mr.bossman075@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
lee.jones@linaro.org
Subject: Re: [PATCH v2] drivers/mfd: simple-mfd-i2c: Add generic compatible
Date: Thu, 26 Jan 2023 14:32:53 +0000 [thread overview]
Message-ID: <Y9KPFbZO+FEgU9G6@google.com> (raw)
In-Reply-To: <CAL_JsqJQd4W5-8ej48hAebvyA6neH=2hTtzVU5HhFpQ2yKsQFw@mail.gmail.com>
On Fri, 20 Jan 2023, Rob Herring wrote:
> On Thu, Jan 19, 2023 at 2:54 PM Lee Jones <lee@kernel.org> wrote:
> >
> > On Thu, 19 Jan 2023, Rob Herring wrote:
> >
> > > On Fri, Dec 02, 2022 at 06:32:26AM -0500, Jesse Taube wrote:
> > > > Some devices may want to use this driver without having a specific
> > > > compatible string. Add a generic compatible string to allow this.
> > >
> > > What devices need this?
> > >
> > > Is that no specific compatible string at all or just in the kernel?
> > > Because the former definitely goes against DT requirements. The latter
> > > enables the former without a schema.
> > >
> > > >
> > > > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> > > > ---
> > > > drivers/mfd/simple-mfd-i2c.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> > > > index f4c8fc3ee463..0bda0dd9276e 100644
> > > > --- a/drivers/mfd/simple-mfd-i2c.c
> > > > +++ b/drivers/mfd/simple-mfd-i2c.c
> > > > @@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
> > > > };
> > > >
> > > > static const struct of_device_id simple_mfd_i2c_of_match[] = {
> > > > + { .compatible = "simple-mfd-i2c-generic" },
> > >
> > > Simple and generic? There is no such device. Anywhere.
> > >
> > > This is also not documented which is how I found it (make
> > > dt_compatible_check). But this should be reverted or dropped rather than
> > > documented IMO.
> >
> > I thought it would be better than having a huge list here.
>
> What indication is there that the list would be huge? We have 2 out of
> 137 MFD bindings. Usually if the MFD is simple, we'd make it a single
> node. It just needs to be clear what the conditions are for using it.
>
> > Devices should *also* be allocated a specific compatible string.
> >
> > $ git grep simple-mfd -- arch
>
> Why can't simple-mfd be used here?
Until this is clarified, agreed and documented, I'm dropping the patch.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-01-26 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 11:32 [PATCH v2] drivers/mfd: simple-mfd-i2c: Add generic compatible Jesse Taube
2022-12-14 18:05 ` Jesse Taube
2022-12-23 12:17 ` Lee Jones
2023-01-05 14:56 ` Lee Jones
2023-01-19 17:51 ` Rob Herring
2023-01-19 20:54 ` Lee Jones
2023-01-19 21:32 ` Jesse Taube
2023-01-20 14:14 ` Rob Herring
2023-01-26 14:32 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KPFbZO+FEgU9G6@google.com \
--to=lee@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mr.bossman075@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).