From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Andrej Valek <andrej.valek@siemens.com>,
linux-input@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling
Date: Tue, 23 Feb 2021 09:30:47 -0800 [thread overview]
Message-ID: <YDU7x/f4ez5nuFn5@google.com> (raw)
In-Reply-To: <20210223102900.GA8833@pengutronix.de>
On Tue, Feb 23, 2021 at 11:29:00AM +0100, Michael Tretter wrote:
> On Tue, 23 Feb 2021 10:02:01 +0100, Geert Uytterhoeven wrote:
> > NORMAL (0x0) and IDLE (0x4) are really two different states. Hence you
> > cannot check for both using a bitmask, as that checks for IDLE only,
> > breaking operation for devices that are in NORMAL state.
>
> Thanks. I missed that the state is actually a value and not a bitfield.
>
> >
> > Fix the wait function to report either state as ready.
> >
> > Fixes: 6524d8eac258452e ("Input: st1232 - add IDLE state as ready condition")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-02-23 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 9:02 [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling Geert Uytterhoeven
2021-02-23 10:29 ` Michael Tretter
2021-02-23 17:30 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDU7x/f4ez5nuFn5@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andrej.valek@siemens.com \
--cc=geert+renesas@glider.be \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).